Rename jsx-sort-prop-types to sort-prop-types #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rule has nothing to do with JSX, so it doesn't make sense for "jsx" to appear in its name. To prevent breaking this rule for people, I have set up jsx-sort-prop-types as an alias with a deprecation warning. Eventually, we should remove it altogether. For the deprecation warning, I borrowed code from jsx-quotes. While I was at it, I corrected some minor wording issues in the documentation for this rule (mostly using "propTypes" instead of "propsTypes"). Fixes jsx-eslint#87.
lencioni
force-pushed
the
sort-prop-types-rename
branch
from
d7bff45 to
02116f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule has nothing to do with JSX, so it doesn't make sense for "jsx"
to appear in its name.
To prevent breaking this rule for people, I have set up
jsx-sort-prop-types as an alias with a deprecation warning. Eventually,
we should remove it altogether. For the deprecation warning, I borrowed
code from jsx-quotes.
While I was at it, I corrected some minor wording issues in the
documentation for this rule (mostly using "propTypes" instead of
"propsTypes").
Fixes #87.