Skip to content

allow es6 class rule to be configured to discourage usage as well #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2015
Merged

allow es6 class rule to be configured to discourage usage as well #359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/rules/prefer-es6-class.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,14 @@ var Components = require('../util/Components');
// ------------------------------------------------------------------------------

module.exports = Components.detect(function(context, components, utils) {
var configuration = context.options[0] || 'always';

return {
ObjectExpression: function(node) {
if (utils.isES5Component(node)) {
if (utils.isES5Component(node) && configuration === 'always') {
context.report(node, 'Component should use es6 class instead of createClass');
} else if (utils.isES6Component(node) && configuration === 'never') {
context.report(node, 'Component should use createClass instead of es6 class');
}
}
};
Expand Down