-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Update README.md #3485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #3485
Conversation
The existing code from the docs will result in `Cannot find module 'eslint-plugin-react/configs/recommended'`. Updated the README page with a working example.
Codecov Report
@@ Coverage Diff @@
## master #3485 +/- ##
=======================================
Coverage 97.57% 97.57%
=======================================
Files 129 129
Lines 9192 9192
Branches 3331 3331
=======================================
Hits 8969 8969
Misses 223 223 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you just removing parts of the readme that were added in #3429?
Please note, just like everywhere on github, you should be reading docs for the tagged version you're using, not just what's on main/master. For npm packages, read the published readme, not the repo's readme. |
I am proposing this change because according to eslint docs, shareable configs are configured in a different way than provided in the current readme.
Would you please give a more detailed explanation, or suggest some documents? My assumption is that the master is the latest stable version. Why is my assumption incorrect?
Thank you for pointing that out. I assumed those readme's were the same. |
That assumption is incorrect - on almost every repo on github - whenever there are unpublished changes, as there are here. |
069314a
to
181c68f
Compare
This seems fine to close, since the readme on master is correct. Happy to reopen after the next release if there's still something that needs changing. |
The existing code from the docs will result in
Cannot find module 'eslint-plugin-react/configs/recommended'
. Updated the README page with a working example.