jsx-eslint · ghost · Apr 8, 2020 · Apr 16, 2020 · Apr 17, 2020 · Apr 17, 2020
diff --git a/lib/rules/boolean-prop-naming.js b/lib/rules/boolean-prop-naming.js
@@ -16,13 +16,13 @@ const propWrapperUtil = require('../util/propWrapper');
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       category: 'Stylistic Issues',
       description: 'Enforces consistent naming for boolean props',
       recommended: false,
       url: docsUrl('boolean-prop-naming')
     },
-
     schema: [{
       additionalProperties: false,
       properties: {

diff --git a/lib/rules/button-has-type.js b/lib/rules/button-has-type.js
@@ -36,6 +36,7 @@ const optionDefaults = {
 
 module.exports = {
   meta: {
+    type: 'problem',
     docs: {
       description: 'Forbid "button" element without an explicit "type" attribute',
       category: 'Possible Errors',

diff --git a/lib/rules/default-props-match-prop-types.js b/lib/rules/default-props-match-prop-types.js
@@ -15,6 +15,7 @@ const docsUrl = require('../util/docsUrl');
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'Enforce all defaultProps are defined and not "required" in propTypes.',
       category: 'Best Practices',

diff --git a/lib/rules/destructuring-assignment.js b/lib/rules/destructuring-assignment.js
@@ -12,6 +12,7 @@ const DEFAULT_OPTION = 'always';
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'Enforce consistent usage of destructuring assignment of props, state, and context',
       category: 'Stylistic Issues',

diff --git a/lib/rules/display-name.js b/lib/rules/display-name.js
@@ -16,6 +16,7 @@ const propsUtil = require('../util/props');
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'Prevent missing displayName in a React component definition',
       category: 'Best Practices',

diff --git a/lib/rules/forbid-component-props.js b/lib/rules/forbid-component-props.js
@@ -19,6 +19,7 @@ const DEFAULTS = ['className', 'style'];
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'Forbid certain props on components',
       category: 'Best Practices',

diff --git a/lib/rules/forbid-dom-props.js b/lib/rules/forbid-dom-props.js
@@ -19,6 +19,7 @@ const DEFAULTS = [];
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'Forbid certain props on DOM Nodes',
       category: 'Best Practices',

diff --git a/lib/rules/forbid-elements.js b/lib/rules/forbid-elements.js
@@ -14,6 +14,7 @@ const docsUrl = require('../util/docsUrl');
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'Forbid certain elements',
       category: 'Best Practices',

diff --git a/lib/rules/forbid-foreign-prop-types.js b/lib/rules/forbid-foreign-prop-types.js
@@ -10,6 +10,7 @@ const ast = require('../util/ast');
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'Forbid using another component\'s propTypes',
       category: 'Best Practices',

diff --git a/lib/rules/forbid-prop-types.js b/lib/rules/forbid-prop-types.js
@@ -22,6 +22,7 @@ const DEFAULTS = ['any', 'array', 'object'];
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'Forbid certain propTypes',
       category: 'Best Practices',

diff --git a/lib/rules/function-component-definition.js b/lib/rules/function-component-definition.js
@@ -98,6 +98,7 @@ function isFunctionExpressionWithName(node) {
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'Standardize the way function component get defined',
       category: 'Stylistic issues',

diff --git a/lib/rules/jsx-boolean-value.js b/lib/rules/jsx-boolean-value.js
@@ -48,6 +48,7 @@ function isNever(configuration, exceptions, propName) {
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'Enforce boolean attributes notation in JSX',
       category: 'Stylistic Issues',

diff --git a/lib/rules/jsx-child-element-spacing.js b/lib/rules/jsx-child-element-spacing.js
@@ -39,13 +39,14 @@ const INLINE_ELEMENTS = new Set([
 
 module.exports = {
   meta: {
+    type: 'layout',
     docs: {
       description: 'Ensures inline tags are not rendered without spaces between them',
       category: 'Stylistic Issues',
       recommended: false,
       url: docsUrl('jsx-child-element-spacing')
     },
-    fixable: null,
+    // fixable: null,
     schema: [
       {
         type: 'object',

diff --git a/lib/rules/jsx-closing-bracket-location.js b/lib/rules/jsx-closing-bracket-location.js
@@ -13,13 +13,14 @@ const docsUrl = require('../util/docsUrl');
 // ------------------------------------------------------------------------------
 module.exports = {
   meta: {
+    type: 'layout',
     docs: {
       description: 'Validate closing bracket location in JSX',
       category: 'Stylistic Issues',
       recommended: false,
       url: docsUrl('jsx-closing-bracket-location')
     },
-    fixable: 'code',
+    fixable: 'whitespace',
 
     schema: [{
       oneOf: [

diff --git a/lib/rules/jsx-closing-tag-location.js b/lib/rules/jsx-closing-tag-location.js
@@ -13,6 +13,7 @@ const docsUrl = require('../util/docsUrl');
 // ------------------------------------------------------------------------------
 module.exports = {
   meta: {
+    type: 'layout',
     docs: {
       description: 'Validate closing tag location for multiline JSX',
       category: 'Stylistic Issues',

diff --git a/lib/rules/jsx-curly-brace-presence.js b/lib/rules/jsx-curly-brace-presence.js
@@ -32,6 +32,7 @@ const DEFAULT_CONFIG = {props: OPTION_NEVER, children: OPTION_NEVER};
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description:
         'Disallow unnecessary JSX expressions when literals alone are sufficient ' +

diff --git a/lib/rules/jsx-curly-newline.js b/lib/rules/jsx-curly-newline.js
@@ -36,16 +36,13 @@ function getNormalizedOption(context) {
 module.exports = {
   meta: {
     type: 'layout',
-
     docs: {
       description: 'Enforce consistent line breaks inside jsx curly',
       category: 'Stylistic Issues',
       recommended: false,
       url: docsUrl('jsx-curly-newline')
     },
-
     fixable: 'whitespace',
-
     schema: [
       {
         oneOf: [

diff --git a/lib/rules/jsx-curly-spacing.js b/lib/rules/jsx-curly-spacing.js
@@ -26,13 +26,14 @@ const SPACING_VALUES = [SPACING.always, SPACING.never];
 
 module.exports = {
   meta: {
+    type: 'layout',
     docs: {
       description: 'Enforce or disallow spaces inside of curly braces in JSX attributes',
       category: 'Stylistic Issues',
       recommended: false,
       url: docsUrl('jsx-curly-spacing')
     },
-    fixable: 'code',
+    fixable: 'whitespace',
 
     schema: {
       definitions: {

diff --git a/lib/rules/jsx-equals-spacing.js b/lib/rules/jsx-equals-spacing.js
@@ -13,13 +13,14 @@ const docsUrl = require('../util/docsUrl');
 
 module.exports = {
   meta: {
+    type: 'layout',
     docs: {
       description: 'Disallow or enforce spaces around equal signs in JSX attributes',
       category: 'Stylistic Issues',
       recommended: false,
       url: docsUrl('jsx-equals-spacing')
     },
-    fixable: 'code',
+    fixable: 'whitespace',
 
     schema: [{
       enum: ['always', 'never']

diff --git a/lib/rules/jsx-filename-extension.js b/lib/rules/jsx-filename-extension.js
@@ -22,6 +22,7 @@ const DEFAULTS = {
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'Restrict file extensions that may contain JSX',
       category: 'Stylistic Issues',

diff --git a/lib/rules/jsx-first-prop-new-line.js b/lib/rules/jsx-first-prop-new-line.js
@@ -13,13 +13,14 @@ const docsUrl = require('../util/docsUrl');
 
 module.exports = {
   meta: {
+    type: 'layout',
     docs: {
       description: 'Ensure proper position of the first property in JSX',
       category: 'Stylistic Issues',
       recommended: false,
       url: docsUrl('jsx-first-prop-new-line')
     },
-    fixable: 'code',
+    fixable: 'whitespace',
 
     schema: [{
       enum: ['always', 'never', 'multiline', 'multiline-multiprop']

diff --git a/lib/rules/jsx-fragments.js b/lib/rules/jsx-fragments.js
@@ -21,6 +21,7 @@ function replaceNode(source, node, text) {
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'Enforce shorthand or standard form for React fragments',
       category: 'Stylistic Issues',

diff --git a/lib/rules/jsx-handler-names.js b/lib/rules/jsx-handler-names.js
@@ -13,6 +13,7 @@ const docsUrl = require('../util/docsUrl');
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'Enforce event handler naming conventions in JSX',
       category: 'Stylistic Issues',

diff --git a/lib/rules/jsx-indent-props.js b/lib/rules/jsx-indent-props.js
@@ -38,13 +38,14 @@ const docsUrl = require('../util/docsUrl');
 // ------------------------------------------------------------------------------
 module.exports = {
   meta: {
+    type: 'layout',
     docs: {
       description: 'Validate props indentation in JSX',
       category: 'Stylistic Issues',
       recommended: false,
       url: docsUrl('jsx-indent-props')
     },
-    fixable: 'code',
+    fixable: 'whitespace',
 
     schema: [{
       oneOf: [{

diff --git a/lib/rules/jsx-indent.js b/lib/rules/jsx-indent.js
@@ -40,6 +40,7 @@ const docsUrl = require('../util/docsUrl');
 // ------------------------------------------------------------------------------
 module.exports = {
   meta: {
+    type: 'layout',
     docs: {
       description: 'Validate JSX indentation',
       category: 'Stylistic Issues',

diff --git a/lib/rules/jsx-key.js b/lib/rules/jsx-key.js
@@ -20,6 +20,7 @@ const defaultOptions = {
 
 module.exports = {
   meta: {
+    type: 'problem',
     docs: {
       description: 'Report missing `key` props in iterators/collection literals',
       category: 'Possible Errors',

diff --git a/lib/rules/jsx-max-depth.js b/lib/rules/jsx-max-depth.js
@@ -15,6 +15,7 @@ const docsUrl = require('../util/docsUrl');
 // ------------------------------------------------------------------------------
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'Validate JSX maximum depth',
       category: 'Stylistic Issues',

diff --git a/lib/rules/jsx-max-props-per-line.js b/lib/rules/jsx-max-props-per-line.js
@@ -13,13 +13,14 @@ const docsUrl = require('../util/docsUrl');
 
 module.exports = {
   meta: {
+    type: 'layout',
     docs: {
       description: 'Limit maximum of props on a single line in JSX',
       category: 'Stylistic Issues',
       recommended: false,
       url: docsUrl('jsx-max-props-per-line')
     },
-    fixable: 'code',
+    fixable: 'whitespace',
     schema: [{
       type: 'object',
       properties: {

diff --git a/lib/rules/jsx-no-bind.js b/lib/rules/jsx-no-bind.js
@@ -25,6 +25,7 @@ const violationMessageStore = {
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'Prevents usage of Function.prototype.bind and arrow functions in React component props',
       category: 'Best Practices',

diff --git a/lib/rules/jsx-no-comment-textnodes.js b/lib/rules/jsx-no-comment-textnodes.js
@@ -31,6 +31,7 @@ function checkText(node, context) {
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'Comments inside children section of tag should be placed inside braces',
       category: 'Possible Errors',

diff --git a/lib/rules/jsx-no-duplicate-props.js b/lib/rules/jsx-no-duplicate-props.js
@@ -14,6 +14,7 @@ const docsUrl = require('../util/docsUrl');
 
 module.exports = {
   meta: {
+    type: 'problem',
     docs: {
       description: 'Enforce no duplicate props',
       category: 'Possible Errors',

diff --git a/lib/rules/jsx-no-literals.js b/lib/rules/jsx-no-literals.js
@@ -18,6 +18,7 @@ function trimIfString(val) {
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'Prevent using string literals in React component definition',
       category: 'Stylistic Issues',

diff --git a/lib/rules/jsx-no-script-url.js b/lib/rules/jsx-no-script-url.js
@@ -44,6 +44,7 @@ function shouldVerifyProp(node, config) {
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'Forbid `javascript:` URLs',
       category: 'Best Practices',

diff --git a/lib/rules/jsx-no-target-blank.js b/lib/rules/jsx-no-target-blank.js
@@ -61,6 +61,7 @@ function hasSecureRel(element, allowReferrer) {
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'Forbid target="_blank" attribute without rel="noopener noreferrer"',
       category: 'Best Practices',

diff --git a/lib/rules/jsx-no-undef.js b/lib/rules/jsx-no-undef.js
@@ -14,6 +14,7 @@ const jsxUtil = require('../util/jsx');
 
 module.exports = {
   meta: {
+    type: 'problem',
     docs: {
       description: 'Disallow undeclared variables in JSX',
       category: 'Possible Errors',

diff --git a/lib/rules/jsx-one-expression-per-line.js b/lib/rules/jsx-one-expression-per-line.js
@@ -18,6 +18,7 @@ const optionDefaults = {
 
 module.exports = {
   meta: {
+    type: 'layout',
     docs: {
       description: 'Limit to one expression per line in JSX',
       category: 'Stylistic Issues',

diff --git a/lib/rules/jsx-pascal-case.js b/lib/rules/jsx-pascal-case.js
@@ -26,6 +26,7 @@ const ALL_CAPS_TAG_REGEX = XRegExp('^[\\p{Lu}0-9]+([\\p{Lu}0-9_]*[\\p{Lu}0-9]+)?
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'Enforce PascalCase for user-defined JSX components',
       category: 'Stylistic Issues',

diff --git a/lib/rules/jsx-props-no-multi-spaces.js b/lib/rules/jsx-props-no-multi-spaces.js
@@ -13,13 +13,14 @@ const docsUrl = require('../util/docsUrl');
 
 module.exports = {
   meta: {
+    type: 'layout',
     docs: {
       description: 'Disallow multiple spaces between inline JSX props',
       category: 'Stylistic Issues',
       recommended: false,
       url: docsUrl('jsx-props-no-multi-spaces')
     },
-    fixable: 'code',
+    fixable: 'whitespace',
     schema: []
   },
 

diff --git a/lib/rules/jsx-props-no-spreading.js b/lib/rules/jsx-props-no-spreading.js
@@ -25,6 +25,7 @@ const DEFAULTS = {
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'Prevent JSX prop spreading',
       category: 'Best Practices',

diff --git a/lib/rules/jsx-sort-default-props.js b/lib/rules/jsx-sort-default-props.js
@@ -16,6 +16,7 @@ const propWrapperUtil = require('../util/propWrapper');
 
 module.exports = {
   meta: {
+    type: 'suggestion',
     docs: {
       description: 'Enforce default props alphabetical sorting',
       category: 'Stylistic Issues',