-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[new] add static-property-placement rule #2193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Closed
ljharb
requested changes
Mar 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also like this form to be incorrect code:
class Foo extends React.Component {
static get defaultProps() {}
}
So perhaps we need a third option, static getters
?
Added the I await your feedback. |
@ljharb LGTM? |
ljharb
approved these changes
Apr 12, 2019
1 task
This was referenced Sep 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a rule discussed in these two issues:
static propTypes = ..
instad ofFoo.propTypes = ..
for class-based components #1923I have based the options on @ljharb suggestions from both issues. This is my first attempt at writing a rule so I expect plenty of feedback.
static public field
(ClassProperty
)static getter
{MethodDefinition
)property assignment
(MemberExpression
)Also I have never worked with TypeScript/Flow so I am not sure what (if any) additional changes are needed?
This rule only applies to ES6 classes.
-- Ignored: Stateless functional components can only ever have a
MemberExpression
to declare any of the above properties.-- Ignored: The
React.createClass/createReactClass
can only ever have aProperty
to declare any of the above properties.This does not have
autofix
either but I feel that is a "nice to have" option and could come later.