Skip to content

more friendly message for no-unescaped-entities #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2019
Merged

more friendly message for no-unescaped-entities #2016

merged 1 commit into from
Jan 21, 2019

Conversation

stevemao
Copy link
Contributor

No description provided.

@stevemao stevemao mentioned this pull request Oct 13, 2018
Closed
@stevemao stevemao force-pushed the feature/improve-escape-error branch from c0eb697 to f4dfffd Compare October 14, 2018 08:04
@stevemao
Copy link
Contributor Author

BTW, why is & not in the default?

@stevemao
Copy link
Contributor Author

@ljharb Do you also want to change the option to be array of

{
  char,
  alternatives,
}

This would become a breaking change (change from array of strings)?

@ljharb
Copy link
Member

ljharb commented Dec 15, 2018

I definitely want to avoid a breaking change.

@stevemao stevemao force-pushed the feature/improve-escape-error branch 2 times, most recently from 97edfb0 to 9dde951 Compare December 16, 2018 00:34
stevemao
stevemao commented Dec 16, 2018
View reviewed changes
docs/rules/no-unescaped-entities.md
```

Where `char` is a special character and `alternatives` is the correct escapes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also added docs

@stevemao stevemao force-pushed the feature/improve-escape-error branch from 9dde951 to d806fc8 Compare December 16, 2018 21:44
@ljharb ljharb force-pushed the feature/improve-escape-error branch from 6523eed to 76b6742 Compare January 3, 2019 20:05
@ljharb
Copy link
Member

ljharb commented Jan 3, 2019

(I'm going to hold off merging it for awhile while the 7.12 release settles down)

@ljharb ljharb requested review from EvHaus and yannickcr January 3, 2019 20:07
EvHaus
EvHaus approved these changes Jan 4, 2019
View reviewed changes
Copy link
Collaborator

@EvHaus EvHaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ljharb ljharb merged commit 16121d4 into jsx-eslint:master Jan 21, 2019
@automatops automatops mentioned this pull request May 3, 2019
Merged
1 task
This was referenced Aug 17, 2019
Open
Open
This was referenced Sep 22, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Sep 30, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Oct 29, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Nov 10, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Dec 15, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@EvHaus EvHaus EvHaus approved these changes

@yannickcr yannickcr Awaiting requested review from yannickcr

Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevemao @ljharb @EvHaus