Adding option to print node value

[jlgonzalezdev]

Basically I did some tweaks to the jsx-no-literals rule to be able to print the node value. :)

Fixes #2007.

[ljharb]

Can you elaborate on your use case here? It seems like you're trying to parse eslint rule messages, which is absolutely not a supported thing anywhere in the eslint ecosystem, and not safe to rely on (they can change in any version, not just majors).

[ljharb]

i do not think it makes any sense to add this as a configuration option; if it's useful, it should be in the message for everyone.

[jlgonzalezdev]

Yes, Basically My use case is:
I need to print to the report the hardcoded text found in the JSX templates.
for something like SIGN IN
I need an output like:
Missing JSX expression container around literal string: SIGN IN.

So, I need to print the node value("SIGN IN " in the example above).

I think that context.getSourceCode() instead of node.value would be the right approach for this, I'll be making some changes to my fork.

[ljharb]

@jlgonzalezdev let's remove the option and just do this by default; i don't see any reason not to.

[jlgonzalezdev]

@ljharb ok, removing the option

[ljharb]

Let’s add a space after the colon, and it’d be good to have some kind of boundary markers around the text - backticks or curly quotes, maybe?

Separately, I’m not sure if the trimming is a good idea - if it’s a literal, the whitespace could be important.

[jlgonzalezdev]

Let’s add a space after the colon, and it’d be good to have some kind of boundary markers around the text - backticks or curly quotes, maybe?

Sure, let's use it like this-> : "TEXT"

Separately, I’m not sure if the trimming is a good idea - if it’s a literal, the whitespace could be important.

I think Not having the trimming really impact the readability of the output, in every case that I have work with this kind of output, I have needed to use the trimming. So, I woud like to keep it.

[EvHaus]

LGTM