Skip to content

[New] add sort-default-props and deprecate jsx-sort-default-props #1861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2022
Merged

[New] add sort-default-props and deprecate jsx-sort-default-props #1861

merged 1 commit into from
Oct 10, 2022

Conversation

alexzherdev
Copy link
Contributor

@alexzherdev alexzherdev commented Jun 29, 2018 •
edited
Loading

Pt. 1 of #1834

@alexzherdev
Copy link
Contributor Author

alexzherdev commented Jun 29, 2018 •
edited
Loading

Looks like I need to fix #1817 to improve coverage.
Edit: done

@alexzherdev alexzherdev force-pushed the rename-jsx-sort-default-props branch from 4dc8c4d to e212430 Compare June 30, 2018 02:35
@alexzherdev alexzherdev force-pushed the rename-jsx-sort-default-props branch from e212430 to 8d775a6 Compare July 3, 2018 04:57
@ljharb ljharb requested review from yannickcr, lencioni and EvHaus July 3, 2018 06:50
@ljharb ljharb added the rule label Jul 3, 2018
@alexzherdev alexzherdev force-pushed the rename-jsx-sort-default-props branch from 8d775a6 to 32cb939 Compare July 24, 2018 17:23
@alexzherdev
Copy link
Contributor Author

Just rebased to resolve conflicts

@alexzherdev alexzherdev force-pushed the rename-jsx-sort-default-props branch from 32cb939 to c7fa863 Compare January 12, 2019 04:18
@amannn amannn mentioned this pull request Jan 30, 2019
Closed
@VincentLanglet
Copy link
Contributor

If my PR is merged before yours, you'll have to add my bug fix.
#2182

@VincentLanglet
Copy link
Contributor

@alexzherdev Since my PR #2182 was merged, you have to update the new sort-default-props, or you'll lose the fix I made.

Thanks ;)

@amannn
Copy link

amannn commented Jul 5, 2019

What's the status of this? Looks like this PR was approved and the only thing left to do is to copy over the bugfix mentioned above.

@ljharb
Copy link
Member

ljharb commented Jul 5, 2019

ping @alexzherdev

@alexzherdev alexzherdev force-pushed the rename-jsx-sort-default-props branch 2 times, most recently from fa02359 to bbb029b Compare July 6, 2019 05:27
@alexzherdev
Copy link
Contributor Author

Done

@ljharb ljharb marked this pull request as draft February 6, 2022 07:24
@ljharb ljharb force-pushed the rename-jsx-sort-default-props branch from 56ba1c0 to 61c369c Compare September 30, 2022 20:27
@ljharb ljharb changed the title Add sort-default-props and deprecate jsx-sort-default-props [New] add sort-default-props and deprecate jsx-sort-default-props Sep 30, 2022
@ljharb ljharb added new rule and removed rule labels Sep 30, 2022
@ljharb ljharb removed the request for review from yannickcr September 30, 2022 20:28
@Balantion2020 Balantion2020 mentioned this pull request Jul 18, 2024
Open
This was referenced Jul 18, 2024
Open
Open
@Exkaleburx Exkaleburx mentioned this pull request Jul 18, 2024
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Jul 19, 2024
Open
@richyhoopd richyhoopd mentioned this pull request Jul 20, 2024
Open
@Elenore23 Elenore23 mentioned this pull request Jul 20, 2024
Open
@SpinningRecords SpinningRecords mentioned this pull request Jul 21, 2024
Open
@Luis-Kristen Luis-Kristen mentioned this pull request Jul 21, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request Jul 29, 2024
Open
@Luis-Kristen Luis-Kristen mentioned this pull request Jul 30, 2024
Open
@Balantion2020 Balantion2020 mentioned this pull request Jul 30, 2024
Open
This was referenced Jul 30, 2024
Open
Open
Open
@richyhoopd richyhoopd mentioned this pull request Jul 30, 2024
Open
@Tanver-Hasan Tanver-Hasan mentioned this pull request Jul 31, 2024
Open
@Exkaleburx Exkaleburx mentioned this pull request Aug 1, 2024
Open
@MANAALHARBI MANAALHARBI mentioned this pull request Dec 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@EvHaus EvHaus EvHaus approved these changes

Assignees
No one assigned
Labels
new rule
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexzherdev @VincentLanglet @amannn @ljharb @EvHaus