Skip to content

Allow LHS in destructuring-assignment #1825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alexzherdev
Copy link
Contributor

Resolves #1728

Not sure if this needs to also check that assignment is in the constructor? Also, would the following do anything useful / should this be allowed?

constructor(props, context) {
  this.context.foo = 'blah';
}

}
};`,
options: ['always'],
parser: 'babel-eslint'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test case doesn't require babel-eslint, let's remove this line

@ljharb ljharb added the bug label Jun 14, 2018
@ljharb ljharb requested review from yannickcr, lencioni and EvHaus June 14, 2018 06:15
Copy link
Collaborator

@EvHaus EvHaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ljharb ljharb merged commit 2a674b0 into jsx-eslint:master Jun 14, 2018
@alexzherdev alexzherdev deleted the 1728-destructuring-state-assignment branch June 29, 2018 17:02
This was referenced Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants