Skip to content

Find string literals as a part of BinaryExpressions in jsx-no-literals #1616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 16, 2018
Merged

Find string literals as a part of BinaryExpressions in jsx-no-literals #1616

merged 4 commits into from
Jan 16, 2018

Conversation

jaaberg
Copy link
Contributor

@jaaberg jaaberg commented Dec 17, 2017

Fixes #1511

ljharb
ljharb approved these changes Dec 17, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - should we also add tests for template literals?

@jaaberg
Copy link
Contributor Author

jaaberg commented Dec 17, 2017

There exists tests for <Foo bar={`Test`} /> and <Foo>{\`Test\`}</Foo>, but we could add one for <Foo bar={`Test ${baz}`} /> to be explicit(?)

@ljharb
Copy link
Member

ljharb commented Dec 17, 2017 •
edited
Loading

@jaaberg that'd be great; also {`foo` + 'bar'}, {`foo` + `bar`} and {'foo' + `bar`}?

@jaaberg
Copy link
Contributor Author

jaaberg commented Dec 18, 2017

@ljharb Great, the tests actually uncovered another bug. The rule should find all strings/literals, so {`foo` + 'bar'} should actually give two errors, one for foo and another one for bar.

Added tests in f27ebc2 and fixed in 28581df.

ljharb
ljharb approved these changes Dec 18, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ljharb ljharb added the bug label Dec 18, 2017
EvHaus
EvHaus approved these changes Jan 16, 2018
View reviewed changes
Copy link
Collaborator

@EvHaus EvHaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ljharb ljharb merged commit c2c7a2a into jsx-eslint:master Jan 16, 2018
@renovate renovate bot mentioned this pull request Mar 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@EvHaus EvHaus EvHaus approved these changes

@yannickcr yannickcr Awaiting requested review from yannickcr

@lencioni lencioni Awaiting requested review from lencioni

Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaaberg @ljharb @EvHaus