Add jsx-sort-default-props rule

[b0gok]

Related to #281

• Add support for

var First = createReactClass({
  getDefaultProps: function() {
    return {
      barRequired: "barRequired",
      onBar: "onBar"
    };
  }
});

• Add more tests
• Remove useless code

[ljharb]

Please add some SFC examples in the documentation and tests as well.

[ljharb]

let's make sure all propTypes and defaultProps mentions are surrounded by backticks.

Also, "to be able to find necessary declarations easier at a later time" and "becomes a burden to maintain"

[fsmaia]

Done! Should I fix these typos in sort-prop-types and jsx-sort-props documentation too? Their introduction are identical.

[ljharb]

Can you elaborate about the spread attribute?

I would expect that sorts do not cross a spread boundary, but d, a, ...obj, c, b would be sorted into a, d, ...obj, b, c

[fsmaia]

Any advances? I have some spare time, may I help?

[b0gok]

@fsmaia sorry, haven't free time for a while. So help is welcome :)

[ljharb]

@b0gok the ideal is for you to add @fsmaia to your fork, so they can update this PR directly - if not, then @fsmaia, please post here a link to your commits on your own fork, and I'll add them for you. Please do not open up a duplicate PR.

[b0gok]

@ljharb ok.
@fsmaia I added you as collaborator in my fork.

[fsmaia]

Added some SFC examples in the documentation and tests. Had to change the rule source, 'cause unnecessary/commented code was useful right in SFC scenario.

[fsmaia]

@ljharb: Are we ready to merge? Any further work or change needed? Thanks

[ljharb]

Can we add some good and bad examples in the docs that use spreads?

[ljharb]

Is the wording of this sentence consistent with the other rules?

[ljharb]

Can we add some good and bad examples in the docs that use spreads? (submitted too soon)

Also, a few more tests using spreads, including multiple interleaved ones?

[ljharb]

Also, please rebase and force push this so as to remove merge commits.

[b0gok]

Can we add some good and bad examples in the docs that use spreads?

@ljharb do you mean something like this?

const defaults = {
  foo: "foo"
};
const types = {
  foo: PropTypes.string,
  bar: PropTypes.string
};

function MyStatelessComponent({ foo, bar }) {
  return <div>{foo}{bar}</div>;
}

MyStatelessComponent.propTypes = types;
MyStatelessComponent.defaultProps = {
  ...defaults,
  bar: "bar"
};

[ljharb]

Yes, just like that.

[b0gok]

Added more tests with spreads and examples.

[ljharb]

Seems good. Other collabs should review, tho.

[EvHaus]

Just curious, why not update the existing jsx-sort-props rule to sort defaultProps instead of create a separate rule? Is there a situations where you'd want proptypes sorted one way, but defaults sorted a different way?

[ljharb]

"sort-props" imo applies only to props, not to defaultProps - #281 (comment)

[EvHaus]

LGTM