Add support for Flow IntersectionTypeAnnotation to prop-types and no-unused-prop-types #1404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Aug 29, 2017
|
Hmm - yes, I think that |
|
Added support to This one was a bit harder because the code is structured completely differently from the other 2 rules, even though the props detection should handle all the same cases... hopefully I can fix that issue soon. 😄 |
ljharb
reviewed
Aug 29, 2017
| props: Props; | ||
| static defaultProps = { | ||
| foo: "foo", | ||
| bar: "bar", |
There was a problem hiding this comment.
Can you add a test case where a defaultProp is omitted for a ? prop type, and there's no error? Alternatively, you could just remove the defaultProp for "bar" here.
|
Can confirm that this resolves #1364. Thanks for your work! |
ljharb
approved these changes
Aug 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1364. Fixes #1323.
The following snippet creates an
IntersectionTypeAnnotationwhich was not handled in both rules.I hope the tests/implementation are speaking for themselves on this one 😄 If anyone has any advice for additional test cases please let me know. I didn't test the
React.Component<Props>syntax because I figured these shouldn't affect that implementation, but perhaps it's worth it?