Teach sort-comp rule about getters and setters. #1311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a phenomenal pull request. Phenomenal. |
ljharb
requested changes
Jul 20, 2017
lib/rules/sort-comp.js
Outdated
| @@ -136,6 +136,24 @@ module.exports = { | |||
| } | |||
| } | |||
|
|
|||
| if (method.getter) { | |||
| for (i = 0, j = methodsOrder.length; i < j; i++) { | |||
There was a problem hiding this comment.
var getterIndex = methodsOrder.indexOf('getters');
if (getterIndex > 0) { indexes.push(getterIndex); }
lib/rules/sort-comp.js
Outdated
| } | ||
|
|
||
| if (method.setter) { | ||
| for (i = 0, j = methodsOrder.length; i < j; i++) { |
There was a problem hiding this comment.
var setterIndex = methodsOrder.indexOf('setters');
if (setterIndex > 0) { indexes.push(setterIndex); }
|
Updated! |
ljharb
approved these changes
Jul 20, 2017
| break; | ||
| } | ||
| const staticIndex = methodsOrder.indexOf('static-methods'); | ||
| if (staticIndex >= 0) { |
There was a problem hiding this comment.
Thanks for cleaning these others up too :-) I didn't realize you were following an existing pattern.
There was a problem hiding this comment.
No problem! Easy change.
|
Sorry for the inconvenience; I've just merged a refactor to start using arrow functions. Would you mind rebasing? |
|
No worries, rebased! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wanted to be able to sort our getters and setters and it was mentioned in an issue, so I implemented it. This PR allows getters and setters to be sorted by adding the keywords
gettersand/orsettersto thesort-comprule.Fixes #100