Skip to content

Add Node 8 to Travis and AppVeyor #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2017
Merged

Add Node 8 to Travis and AppVeyor #1278

merged 1 commit into from
Jun 27, 2017

Conversation

lencioni
Copy link
Collaborator

No description provided.

@lencioni lencioni changed the title Add Node 8 to Travis build matrix Add Node 8 to Travis and Appveyor Jun 27, 2017
@lencioni lencioni changed the title Add Node 8 to Travis and Appveyor Add Node 8 to Travis and AppVeyor Jun 27, 2017
ljharb
ljharb requested changes Jun 27, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but before merging we should also disable package-lock in npmrc/gitignore so that npm < 5 and 5+ don't behave differently.

@lencioni
Copy link
Collaborator Author

@ljharb you mean like you did here? 0c36380

ljharb
ljharb approved these changes Jun 27, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, sorry - I could have sworn I hadn't done that yet :-)

@ljharb ljharb merged commit ab7bd25 into master Jun 27, 2017
@ljharb ljharb deleted the node8 branch June 28, 2017 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lencioni @ljharb