v7.12.0 update throws AssertionError [ERR_ASSERTION]: Node must be provided when reporting error if location is not provided at assertValidNodeInfo

[connorsmallman]

v7.12.0 is throws the following error

> eslint --ext .jsx,.js src/ etc/

AssertionError [ERR_ASSERTION]: Node must be provided when reporting error if location is not provided
    at assertValidNodeInfo (/node_modules/eslint/lib/util/report-translator.js:96:9)
    at args (/node_modules/eslint/lib/util/report-translator.js:246:9)
    at Object.report (/node_modules/eslint/lib/linter.js:720:41)
    at reportUndeclaredPropTypes (/node_modules/eslint-plugin-react/lib/rules/prop-types.js:175:17)
    at Program:exit.Object.keys.filter.forEach.component (/node_modules/eslint-plugin-react/lib/rules/prop-types.js:193:11)
    at Array.forEach (<anonymous>)
    at Object.Program:exit (/node_modules/eslint-plugin-react/lib/rules/prop-types.js:192:81)
    at updatedRuleInstructions.(anonymous function) (/node_modules/eslint-plugin-react/lib/util/Components.js:754:75)
    at listeners.(anonymous function).forEach.listener (/node_modules/eslint/lib/util/safe-emitter.js:45:58)
    at Array.forEach (<anonymous>)

[ljharb]

cc @alexzherdev

[ljharb]

Could you provide the code that leads to this?

[jeffrigby]

I'm seeing this too. I use react-router which passes location and match as props. When I compare the location search, it throws this error:

  componentDidUpdate(prevProps) {
    const { match, location} = this.props;
    const searchEquals = prevProps.location.search === location.search;
    ...
  }

[doochik]

Example

const React = require('react');
const PropTypes = require('prop-types');

class MyComponent extends React.PureComponent {
    componentDidUpdate(prevProps) {
        const { items } = this.props;
        const hasNewImage = items.length > prevProps.items.length;
    }

    render() {
        return null;
    }
}

MyComponent.propTypes = {
    items: PropTypes.array,
};

module.exports = MyComponent;

#2099 fixes this bug

[ljharb]

Closed in #2099.

[nicofrand]

Hi,

I am still getting this issue with 7.12.1. Am I the only one? I made sure the package was updated correctly.

Thanks for all the hard work!

[ljharb]

@nicofrand can you file a new issue with the details?

[nicofrand]

Well, I have the exact same error (line numbers etc.). I don't know what I should provide?

[ljharb]

Specifically, the code that makes it crash - but if it’s generating the same error, then I’ll reopen.