Skip to content

no-unknown-property does not allow crossorigin on link tags #1656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
msmichellegar opened this issue Jan 26, 2018 · 2 comments
Closed

no-unknown-property does not allow crossorigin on link tags #1656

msmichellegar opened this issue Jan 26, 2018 · 2 comments

Comments

@msmichellegar
Copy link

msmichellegar commented Jan 26, 2018

In the latest release, there was a fix for the crossorigin property (related to #1642). The updated rule only allows the crossorigin property on script, img and video tags. This means an error is now thrown for the crossorigin property on link tags.

You can see here that crossorigin is an accepted attribute of link tags. I would therefore expect the linter to allow them. Something like this should pass:

<link href="path/to/file.ext" crossorigin="anonymous" />

Unless there's something I'm missing, happy to make a PR to fix this 🌈

@jzDev
Copy link
Contributor

jzDev commented Jan 26, 2018

I created a PR for this change here as well as the correct JSX naming convention #1659

@msmichellegar
Copy link
Author

Great, thank you @jzDev!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants