-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Does jsx-pascal-case break <script crossorigin src="..."></script>? #1642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
If so, that'd be a bug with prettier, not this plugin. Does it happen when you use eslint by itself? |
(jsx-pascal-case applies to component names, not to attribute names) |
It might be the |
@ljharb Thanks for investigating this so quickly! Yeah, it definitely "felt" hard-coded so I think that's the right thing. I think this should be upgraded to a bug and discussed/fixed. It definitely conflicts with React as React is expecting lowercase |
@ljharb Thank you! =) |
It seems there was a confusion on the attribute name convention for crossorigin. The previous reference was not a JSX implementation. I created a PR to fix this issue. #1659 |
@jzDev Interesting. I think |
Using prettier-eslint with react/recommended.
Trying to set script tags within JSX.
React recommends adding
crossorigin
attribute.Prettier keeps pascal-casing the attribute to
crossOrigin
.Possible bug?
The text was updated successfully, but these errors were encountered: