no-context: more tests & corresponding fix

Author: zachguo

lib/rules/no-context.js

@@ -67,8 +67,7 @@ module.exports = {
       return Boolean(
         node &&
         node.params &&
-        node.params[1] &&
-        node.params[1].name === 'context'
+        node.params[1]
       );
     }
 

tests/lib/rules/no-context.js

@@ -54,6 +54,13 @@ ruleTester.run('no-context', rule, {
       '};'
     ].join('\n'),
     parserOptions: parserOptions
+  }, {
+    code: [
+      'const Hello = props => {',
+      '  return <div>Hello {props.name}</div>;',
+      '};'
+    ].join('\n'),
+    parserOptions: parserOptions
   }, {
     code: [
       'class Hello extends React.Component {',
@@ -67,6 +74,19 @@ ruleTester.run('no-context', rule, {
     ].join('\n'),
     parser: 'babel-eslint',
     parserOptions: parserOptions
+  }, {
+    code: [
+      'class Hello extends React.PureComponent {',
+      '  static propTypes = {',
+      '    name: React.PropTypes.string',
+      '  };',
+      '  render() {',
+      '    return <div>Hello {this.props.name}</div>;',
+      '  }',
+      '};'
+    ].join('\n'),
+    parser: 'babel-eslint',
+    parserOptions: parserOptions
   }, {
     code: [
       'class Hello extends React.Component {',
@@ -163,6 +183,22 @@ ruleTester.run('no-context', rule, {
     errors: [{
       message: 'Using context is not allowed.'
     }]
+  }, {
+    code: [
+      'class Hello extends React.PureComponent {',
+      '  static contextTypes = {',
+      '    name: React.PropTypes.string',
+      '  };',
+      '  render() {',
+      '    return <div>Hello</div>;',
+      '  }',
+      '};'
+    ].join('\n'),
+    parser: 'babel-eslint',
+    parserOptions: parserOptions,
+    errors: [{
+      message: 'Using context is not allowed.'
+    }]
   }, {
     code: [
       'class Hello extends React.Component {',
@@ -186,6 +222,36 @@ ruleTester.run('no-context', rule, {
     errors: [{
       message: 'Using context is not allowed.'
     }]
+  }, {
+    code: [
+      'const Hello = (props, contextRenamed) => {',
+      '  return <div>Hello {contextRenamed.name}</div>;',
+      '};'
+    ].join('\n'),
+    parserOptions: parserOptions,
+    errors: [{
+      message: 'Using context is not allowed.'
+    }]
+  }, {
+    code: [
+      'const Hello = (props, {name}) => {',
+      '  return <div>Hello {name}</div>;',
+      '};'
+    ].join('\n'),
+    parserOptions: parserOptions,
+    errors: [{
+      message: 'Using context is not allowed.'
+    }]
+  }, {
+    code: [
+      'const Hello = function(props, context) {',
+      '  return <div>Hello {context.name}</div>;',
+      '};'
+    ].join('\n'),
+    parserOptions: parserOptions,
+    errors: [{
+      message: 'Using context is not allowed.'
+    }]
   }, {
     code: [
       'const Hello = (props, context) => {',