no-context: capture class static properties

Author: zachguo

lib/rules/no-context.js

@@ -109,6 +109,20 @@ module.exports = {
         }
       },
 
+      ObjectExpression: function(node) {
+        node.properties.forEach(function(property) {
+          if (!isContextTypesDeclaration(property.key)) {
+            return;
+          }
+          if (property.value.type === 'ObjectExpression') {
+            context.report({
+              node: node,
+              message: 'Using context is not allowed.'
+            });
+          }
+        });
+      },
+
       FunctionDeclaration: handleStatelessComponent,
 
       ArrowFunctionExpression: handleStatelessComponent,

tests/lib/rules/no-context.js

@@ -34,6 +34,18 @@ ruleTester.run('no-context', rule, {
       '});'
     ].join('\n'),
     parserOptions: parserOptions
+  }, {
+    code: [
+      'var Hello = React.createClass({',
+      '  propTypes: {',
+      '    name: React.PropTypes.string',
+      '  },',
+      '  render: function() {',
+      '    return <div>Hello {this.props.name}</div>;',
+      '  }',
+      '});'
+    ].join('\n'),
+    parserOptions: parserOptions
   }, {
     code: [
       'var Hello = function() {',
@@ -42,6 +54,41 @@ ruleTester.run('no-context', rule, {
       '};'
     ].join('\n'),
     parserOptions: parserOptions
+  }, {
+    code: [
+      'class Hello extends React.Component {',
+      '  static propTypes = {',
+      '    name: React.PropTypes.string',
+      '  };',
+      '  render() {',
+      '    return <div>Hello {this.props.name}</div>;',
+      '  }',
+      '};'
+    ].join('\n'),
+    parser: 'babel-eslint',
+    parserOptions: parserOptions
+  }, {
+    code: [
+      'class Hello extends React.Component {',
+      '  render() {',
+      '    return <div>Hello {this.props.name}</div>;',
+      '  }',
+      '};',
+      'Hello.propTypes = {',
+      '  name: React.PropTypes.string',
+      '};'
+    ].join('\n'),
+    parserOptions: parserOptions
+  }, {
+    code: [
+      'var First = React.createClass({',
+      '  propTypes: externalPropTypes,',
+      '  render: function() {',
+      '    return <div />;',
+      '  }',
+      '});'
+    ].join('\n'),
+    parserOptions: parserOptions
   }],
 
   invalid: [{
@@ -56,6 +103,23 @@ ruleTester.run('no-context', rule, {
     errors: [{
       message: 'Using context is not allowed.'
     }]
+  }, {
+    code: [
+      'var Hello = React.createClass({',
+      '  contextTypes: {',
+      '    name: React.PropTypes.string',
+      '  },',
+      '  render: function() {',
+      '    return <div>Hello {this.context.name}</div>;',
+      '  }',
+      '});'
+    ].join('\n'),
+    parserOptions: parserOptions,
+    errors: [{
+      message: 'Using context is not allowed.'
+    }, {
+      message: 'Using context is not allowed.'
+    }]
   }, {
     code: [
       'class Hello extends React.Component {',
@@ -83,6 +147,22 @@ ruleTester.run('no-context', rule, {
     errors: [{
       message: 'Using context is not allowed.'
     }]
+  }, {
+    code: [
+      'class Hello extends React.Component {',
+      '  static contextTypes = {',
+      '    name: React.PropTypes.string',
+      '  };',
+      '  render() {',
+      '    return <div>Hello</div>;',
+      '  }',
+      '};'
+    ].join('\n'),
+    parser: 'babel-eslint',
+    parserOptions: parserOptions,
+    errors: [{
+      message: 'Using context is not allowed.'
+    }]
   }, {
     code: [
       'class Hello extends React.Component {',