Skip to content

Commit 36edd13

Browse files
committed
improve error message
1 parent 2b9f076 commit 36edd13

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

lib/rules/jsx-no-leaked-zero.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ const isParenthesised = require('../util/ast').isParenthesised;
1414
//------------------------------------------------------------------------------
1515

1616
const messages = {
17-
noPotentialNumericEvaluation: 'Potential numeric evaluation that ends up in leaked zero to the DOM',
17+
noPotentialNumericEvaluation: 'Potential numeric evaluation resulting in an unintentionally rendered `0`',
1818
};
1919

2020
const VALID_LEFT_SIDE_EXPRESSIONS = ['UnaryExpression', 'BinaryExpression', 'ConditionalExpression', 'CallExpression'];

tests/lib/rules/jsx-no-leaked-zero.js

+12-12
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ ruleTester.run('jsx-no-leaked-zero', rule, {
104104
`,
105105
options: [{ fixStrategy: 'cast' }],
106106
errors: [{
107-
message: 'Potential numeric evaluation that ends up in leaked zero to the DOM',
107+
message: 'Potential numeric evaluation resulting in an unintentionally rendered `0`',
108108
line: 3,
109109
column: 22,
110110
}],
@@ -122,7 +122,7 @@ ruleTester.run('jsx-no-leaked-zero', rule, {
122122
`,
123123
options: [{ fixStrategy: 'cast' }],
124124
errors: [{
125-
message: 'Potential numeric evaluation that ends up in leaked zero to the DOM',
125+
message: 'Potential numeric evaluation resulting in an unintentionally rendered `0`',
126126
line: 3,
127127
column: 22,
128128
}],
@@ -140,7 +140,7 @@ ruleTester.run('jsx-no-leaked-zero', rule, {
140140
`,
141141
options: [{ fixStrategy: 'cast' }],
142142
errors: [{
143-
message: 'Potential numeric evaluation that ends up in leaked zero to the DOM',
143+
message: 'Potential numeric evaluation resulting in an unintentionally rendered `0`',
144144
line: 3,
145145
column: 22,
146146
}],
@@ -158,7 +158,7 @@ ruleTester.run('jsx-no-leaked-zero', rule, {
158158
`,
159159
options: [{ fixStrategy: 'cast' }],
160160
errors: [{
161-
message: 'Potential numeric evaluation that ends up in leaked zero to the DOM',
161+
message: 'Potential numeric evaluation resulting in an unintentionally rendered `0`',
162162
line: 3,
163163
column: 22,
164164
}],
@@ -176,7 +176,7 @@ ruleTester.run('jsx-no-leaked-zero', rule, {
176176
`,
177177
options: [{ fixStrategy: 'cast' }],
178178
errors: [{
179-
message: 'Potential numeric evaluation that ends up in leaked zero to the DOM',
179+
message: 'Potential numeric evaluation resulting in an unintentionally rendered `0`',
180180
line: 3,
181181
column: 22,
182182
}],
@@ -194,7 +194,7 @@ ruleTester.run('jsx-no-leaked-zero', rule, {
194194
`,
195195
options: [{ fixStrategy: 'cast' }],
196196
errors: [{
197-
message: 'Potential numeric evaluation that ends up in leaked zero to the DOM',
197+
message: 'Potential numeric evaluation resulting in an unintentionally rendered `0`',
198198
line: 3,
199199
column: 23,
200200
}],
@@ -213,7 +213,7 @@ ruleTester.run('jsx-no-leaked-zero', rule, {
213213
}
214214
`,
215215
errors: [{
216-
message: 'Potential numeric evaluation that ends up in leaked zero to the DOM',
216+
message: 'Potential numeric evaluation resulting in an unintentionally rendered `0`',
217217
line: 3,
218218
column: 22,
219219
}],
@@ -230,7 +230,7 @@ ruleTester.run('jsx-no-leaked-zero', rule, {
230230
}
231231
`,
232232
errors: [{
233-
message: 'Potential numeric evaluation that ends up in leaked zero to the DOM',
233+
message: 'Potential numeric evaluation resulting in an unintentionally rendered `0`',
234234
line: 3,
235235
column: 22,
236236
}],
@@ -247,7 +247,7 @@ ruleTester.run('jsx-no-leaked-zero', rule, {
247247
}
248248
`,
249249
errors: [{
250-
message: 'Potential numeric evaluation that ends up in leaked zero to the DOM',
250+
message: 'Potential numeric evaluation resulting in an unintentionally rendered `0`',
251251
line: 3,
252252
column: 22,
253253
}],
@@ -264,7 +264,7 @@ ruleTester.run('jsx-no-leaked-zero', rule, {
264264
}
265265
`,
266266
errors: [{
267-
message: 'Potential numeric evaluation that ends up in leaked zero to the DOM',
267+
message: 'Potential numeric evaluation resulting in an unintentionally rendered `0`',
268268
line: 3,
269269
column: 22,
270270
}],
@@ -281,7 +281,7 @@ ruleTester.run('jsx-no-leaked-zero', rule, {
281281
}
282282
`,
283283
errors: [{
284-
message: 'Potential numeric evaluation that ends up in leaked zero to the DOM',
284+
message: 'Potential numeric evaluation resulting in an unintentionally rendered `0`',
285285
line: 3,
286286
column: 22,
287287
}],
@@ -299,7 +299,7 @@ ruleTester.run('jsx-no-leaked-zero', rule, {
299299
`,
300300
options: [{ fixStrategy: 'ternary' }],
301301
errors: [{
302-
message: 'Potential numeric evaluation that ends up in leaked zero to the DOM',
302+
message: 'Potential numeric evaluation resulting in an unintentionally rendered `0`',
303303
line: 3,
304304
column: 23,
305305
}],

0 commit comments

Comments
 (0)