move operator check to AST selector

Belco90 · Belco90 · commit 2b9f07695692 · 2022-02-28T17:41:26.000+01:00
diff --git a/lib/rules/jsx-no-leaked-zero.js b/lib/rules/jsx-no-leaked-zero.js
@@ -81,12 +81,8 @@ module.exports = {
     }
 
     return {
-      'JSXExpressionContainer > LogicalExpression'(node) {
+      'JSXExpressionContainer > LogicalExpression[operator="&&"]'(node) {
         const leftSide = node.left;
-        if (node.operator !== '&&') {
-          return;
-        }
-
         if (VALID_LEFT_SIDE_EXPRESSIONS.includes(leftSide.type)) {
           return;
         }

Original file line number	Diff line number	Diff line change
`@@ -81,12 +81,8 @@ module.exports = {`
`81`	`81`	`}`
`82`	`82`
`83`	`83`	`return {`
`84`		`- 'JSXExpressionContainer > LogicalExpression'(node) {`
	`84`	`+ 'JSXExpressionContainer > LogicalExpression[operator="&&"]'(node) {`
`85`	`85`	`const leftSide = node.left;`
`86`		`- if (node.operator !== '&&') {`
`87`		`- return;`
`88`		`- }`
`89`		`-`
`90`	`86`	`if (VALID_LEFT_SIDE_EXPRESSIONS.includes(leftSide.type)) {`
`91`	`87`	`return;`
`92`	`88`	`}`