adding glob to label-has-associated-control #735
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Aug 19, 2020
Comment on lines
+61
to
+66
| '*Input', | ||
| '*Meter', | ||
| '*Output', | ||
| '*Progress', | ||
| '*Select', | ||
| '*Textarea', |
There was a problem hiding this comment.
Thanks for the PR! I'm not sure how this actually resolves the issue tho - these are just the defaults (which should not have asterisks). mayContainChildComponent is what likely needs to be tweaked to support stars.
There was a problem hiding this comment.
Hi Jordan, thanks for your comment. I'm going to modify mayContainChildComponent and was going to include the package, picoMatch, for globs. Does this work? Thanks again.
There was a problem hiding this comment.
I'd prefer using minimatch, but sounds great thanks
|
Thank you for the PR @lilia-paz . Please reopen this PR when you plan to continue working on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #720
Request to add glob or regex to controlComponents in label-has-associated-control. Added glob to components