Skip to content

fix: require missing 'autocomplete-valid' rule #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2020
Merged

fix: require missing 'autocomplete-valid' rule #661

merged 1 commit into from
Jan 30, 2020

Conversation

dustin-ruetz
Copy link
Contributor

@dustin-ruetz dustin-ruetz commented Jan 30, 2020

Recently I noticed this issue when I attempted to extend the recommended eslint-plugin-jsx-a11y configuration in a codebase (trimmed ESLint config file below).

// .eslintrc.js
module.exports = {
  extends: [
    'eslint:recommended',
    'plugin:jsx-a11y/recommended'
  ],
}

After I did this I opened one of my React component files. The ESLint editor plugin in VS Code showed an error: Definition for rule 'jsx-a11y/autocomplete-valid' was not found. eslint(jsx-a11y/autocomplete-valid)

After checking the eslint-plugin-jsx-a11y src/index.js file I noticed that the 'autocomplete-valid' rule was not being required. This pull request should fix the issue.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 99.484% when pulling 33670bb on dustin-ruetz:patch-1 into 99a4868 on evcohen:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 99.484% when pulling 33670bb on dustin-ruetz:patch-1 into 99a4868 on evcohen:master.

@ljharb ljharb added the bug label Jan 30, 2020
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch

@ljharb ljharb merged commit 46369c3 into jsx-eslint:master Jan 30, 2020
@arvigeus
Copy link

Just hit that issue too. I thought I was doing something wrong

@dustin-ruetz
Copy link
Contributor Author

@ljharb Any idea when the next release will be, or is that something that only @evcohen can do?

@ljharb
Copy link
Member

ljharb commented Jan 31, 2020

When i get to it :-)

@jsphstls
Copy link

Just hit this same issue.

@ljharb
Copy link
Member

ljharb commented Jul 17, 2020

@jsphstls it's since been released; you may need to update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants