Control has associated label

[jessebeach]

This rule is the inverse of label-has-associated-control.

Check the Markdown file for details of the rule.

It's intended to catch unlabelled buttons, checkboxes, radios, menuitems, options, etc. I did a bunch of QA work to finagle the configs so that the output is actionable.

The danger here is that we encourage developers to put labels on things like containers, which really shouldn't be labelled. The exceptions to that rule are dialogs and alerts, but I opened a new issue to write a rule for those: #516

There really isn't a difference between the behavior of recommended and strict, so I made the configs the same for both.

[coveralls]

Coverage increased (+0.004%) to 99.445% when pulling 3544dfd on jessebeach:control-has-associated-label into e53906d on evcohen:master.

[coveralls]

Coverage increased (+0.01%) to 99.457% when pulling 5650674 on jessebeach:control-has-associated-label into 9924d03 on evcohen:master.

[jessebeach]

Should we enforce a label on canvas, audio and video tags?

[jessebeach]

I'm testing the rule on the FB codebase right now and fine-tuning it. It's over-capturing a little.

[ljharb]

It seems like maybe the default should be to enforce a label on everything, but maybe have an option to ignore input types that aren't that important to label, like canvas/audio/video?

[jessebeach]

The results from my internal tests look good. About 250 errors over ~70K files. Keep in mind that we've done a TON of work to ferret out unlabelled elements. These represent the ones that we had no signal for.

I just need to fill out the control-has-associated-label.md file and this rule should be good to go.

[jessebeach]

I'm finding lots of juicy examples where all the rules in the plugin have been followed except that the element doesn't have a label. This is the last step!

[jessebeach]

@ljharb @evcohen thoughts on merging this new rule in? I ran it over the FB codebase and the results are great. Fixable and accurate.

[ljharb]

This seems great. It'd be ideal to rebase this first, so there's no merge commits, but otherwise let's merge, and cut a minor release :-D

[keithmadden-toast]

@jessebeach Wasn't sure if I should open an issue for this but this PR adds control-has-associated-label to recommended & strict modes but only disables label-has-for for recommended. Is that the intended behaviour? I'm happy to create a follow-up PR if not 🙂

[backwardok]

Hey @jessebeach ! I was looking through some of the rules that exist and I noticed that this rule isn't enabled for either recommended or strict. Was that intended? I mostly ask because the Airbnb config uses it and I was surprised it wasn't listed on the README as an available rule

[ljharb]

@backwardok adding a new rule to a builtin config is a breaking change, so it's planned for whenever we end up doing a semver-major bump.