Skip to content

More easier plugin:jsx-a11y/{recommended,strict} configs #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2018

Conversation

ybiquitous
Copy link
Contributor

This makes setting plugins unnecessary when using plugin:jsx-a11y/*** configs.

Before

{
  "extends": ["plugin:jsx-a11y/recommended"],
  "plugins": ["jsx-a11y"]
}

After

{
  "extends": ["plugin:jsx-a11y/recommended"]
}

For example, eslint-plugin-react has a similar behavior:

https://github.com/yannickcr/eslint-plugin-react/blob/3008e85553b0ba66f396e2d6690eea420838bfec/index.js#L117

This makes setting `plugins` unnecessary when using `plugin:jsx-a11y/***` configs.

Before
------

```json
{
  "extends": ["plugin:jsx-a11y/recommended"],
  "plugins": ["jsx-a11y"]
}
```

After
-----

```json
{
  "extends": ["plugin:jsx-a11y/recommended"]
}
```

For example, `eslint-plugin-react` has a similar behavior:

https://github.com/yannickcr/eslint-plugin-react/blob/3008e85553b0ba66f396e2d6690eea420838bfec/index.js#L117
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.442% when pulling 0f6a8af on ybiquitous:set-plugins-to-configs into 93265cb on evcohen:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.442% when pulling 0f6a8af on ybiquitous:set-plugins-to-configs into 93265cb on evcohen:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.442% when pulling 0f6a8af on ybiquitous:set-plugins-to-configs into 93265cb on evcohen:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.442% when pulling 0f6a8af on ybiquitous:set-plugins-to-configs into 93265cb on evcohen:master.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great change that should have been here the whole time. Thanks!

@ljharb ljharb merged commit 6596435 into jsx-eslint:master Nov 7, 2018
@ybiquitous ybiquitous deleted the set-plugins-to-configs branch November 7, 2018 18:28
@ybiquitous
Copy link
Contributor Author

Thank you so much for quick reply! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants