Skip to content

Clarify what "absolute" means for keyword absolute location #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

handrews
Copy link
Contributor

It is like absolute filesystem paths, not like absolute-URI
from RFC 3986. In fact, an absolute keyword location can
never be an RFC 3986 absolute-URI because a fragment must always
be present to identify the keyword.

NOTE: this PR is not for any discussion of renaming fields in the output format, since someone always wants to rename something. If you want to rename something, get consensus around it and file it as a new issue/PR. Do not raise it here.

It is like absolute filesystem paths, not like absolute-URI
from RFC 3986.  In fact, an absolute keyword location can
never be an RFC 3986 absolute-URI because a fragment must always
be present to identify the keyword.
@handrews handrews added this to the draft-08-patch1 milestone Sep 26, 2020
@handrews handrews changed the title Clarify what "absolute" means for kwd loc Clarify what "absolute" means for keyword absolute location Sep 26, 2020
@handrews handrews merged commit 78413ee into json-schema-org:master Oct 1, 2020
@karenetheridge
Copy link
Member

extremely minor nit - the absoluteKeywordLocation for the error generated by the schema false won't have a non-empty fragment.

(That's the only time this can happen, I believe, except for implementation-specific errors generated outside of keyword evaluation.. for example hitting a maximum recursion limit right after an $id changed the canonical uri)

@handrews handrews deleted the abs branch September 22, 2022 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants