Note undefined behavior with unknown $ref targets #713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the CI build is failing because of segmentation faults in xml2rfc, which has to be some sort of environmental problem. They build fine locally, and FFS how does XML provoke a segfault? Is there a buggy version of xml2rfc? |
handrews
force-pushed
the
unknown-targets
branch
from
0fa1ba2 to
66abb7c
Compare
handrews
force-pushed
the
unknown-targets
branch
from
66abb7c to
6b1d135
Compare
The most common situation here, which are basically alternate names for "definitions" or "$defs", will generally work, but this makes clear that there is no obligation to attempt to guarantee the proper behavior in such situations. We might want to narrow this behavior down in the future, but for now this at least clearly removes any possible burdensome and totally impractical inferencing requirements.
Whether the target is definitely not a schema or simply unknown and therefore not necessarily a schema, the result of $ref-ing it is undefined. Only references to targets that the implementation can determine with certainty to be schemas have well-defined behavior.
handrews
force-pushed
the
unknown-targets
branch
from
6b1d135 to
e741b8e
Compare
Relequestual
approved these changes
Mar 20, 2019
|
@Relequestual I'll do the change log as a batch near the end- lots of things are missing, but the issues are all tagged with the milestone so it won't be hard to go through and write it up. |
gregsdennis
added
clarification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #687 (in the sense of "it's clear what you are and are not required to implement", not in the sense of "solves the underlying applicator keyword recognition issue", which will be part of the draft after this as it is quite involved").
The most common situation here, which are basically alternate
names for "definitions" or "$defs", will generally work, but
this makes clear that there is no obligation to attempt to
guarantee the proper behavior in such situations.
We might want to narrow this behavior down in the future,
but for now this at least clearly removes any possible burdensome
and totally impractical inferencing requirements.