More guidance on initial base URI #686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nudge readers a bit more clearly to consider things like 'file://' URLs and not just network URLs when constructing a location-based base URI. Also refer directly to the rules for application-specific default URIs.
gregsdennis
approved these changes
Dec 1, 2018
Julian
approved these changes
Dec 3, 2018
gregsdennis
added
clarification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nudge readers a bit more clearly to consider things like 'file://'
URLs and not just network URLs when constructing a location-based
base URI. Also refer directly to the rules for application-specific
default URIs.
This was motivated by python-jsonschema/jsonschema#343 (comment) over at @Julian 's implementation repo. And I'm pretty sure I have seen similar confusion from users, or unexpected/unexplained behaviors from implementations elsewhere.
Referring to RFC 3986 section 5.1.4 also points people to the "if you send a thing you are responsible for it having a base URI" guidance.