Remove duplication and descriptions. #402
Conversation
We regularly forget about links.json. Let's use $ref and prevent that. Also, remove all of the descriptions. They are not present in the core/validation schema and have gotten out of sync several times. The descriptions tend to be either trivial or inadequate as the more complex features aren't easily described in a readable amount of JSON text. This addresses json-schema-org#175
There was a problem hiding this comment.
The single commit packs unrelated things; some mentioned in the commit message and some not (like updates of links.json). This makes it hard to review, as far as I am concerned.
Would you mind splitting this into atomic commits? (For instance: "update links.json with recently added keywords", "remove descriptions" and "use $ref to links.json".)
|
Remove description |
|
@dlax I apologize for snapping at you over this, it's not OK. This is a reasonable request (which, to be clear, doesn't make it any more or less OK than snapping over an unreasonably request). I'm not going to re-submit it, for reasons that I have explained to @dlax off-list so that he knows that they are unrelated to him. I'm just going to avoid doing PRs where I'm likely to find myself having this sort of reaction, as it's probably the most reliable way for me to avoid causing a problem in the future. |
We regularly forget about links.json. Let's use $ref and prevent
that.
Also, remove all of the descriptions. They are not present in the
core/validation schema and have gotten out of sync several times.
The descriptions tend to be either trivial or inadequate as the
more complex features aren't easily described in a readable amount
of JSON text.
This addresses #175