-
-
Notifications
You must be signed in to change notification settings - Fork 309
Add "anchorPointer" for in-instance contexts #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks promising. I'll come back later for a second reading and validation.
Spotted a few typos.
jsonschema-hyperschema.xml
Outdated
"properties": { | ||
"name": {"type": "string"} | ||
} | ||
}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra }
jsonschema-hyperschema.xml
Outdated
"id": {"type": "integer"} | ||
}, | ||
"links": [{ | ||
"rel": "item" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing trailing ,
jsonschema-hyperschema.xml
Outdated
}]]> | ||
</artwork> | ||
<postamble> | ||
The default context for the the link to "/example/1234" is the first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"the the"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, it should be "/examples/1234"
I guess (same below).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, correct on all accounts. Should be fixed now.
The updated commit is just rebased to resolve conflicts after merging There are no changes whatsoever to the overall contents of the PR. |
The additional commit pushed just now makes minor changes since "anchor" has now been merged, and this keyword builds on that concept. |
@handrews We should add the new keyword to the meta-schema, I guess? |
Oops- that was one of the post-"anchor"-merge fixups I was going to do, otherwise they would conflict as I'd put them in the same place. Will update momentarily. |
This will need a bit more work after "anchor" is merged in, as the improved wording about what the default context is is all in that other PR. But the key points are well enough developed for review. In the interst of getting the main points out for review, I referenced the long-expired Relative JSON Pointer I-D. Maybe that's OK since this is not even a working group document yet, or we can talk about how to either move the relevant parts in, or re-submit that I-D ourselves as well. This goes along with "hrefPointers", which adjusts template variable resolution in the same way that this keyword adjusts context location.
Now that "anchor" has been merged, there are a few points where its text and that of the "anchorPointer" proposal needed adjusting to fit with each other properly.
Also align the wording around JSON Pointers and Relative JSON Pointers with the wording in the "hrefPointers" specification.
This will need a bit more work after "anchor" (#352) is merged in,
as the improved wording about what the default context is
is all in that other PR. But the key points are well enough
developed for review.
In the interst of getting the main points out for review, I
referenced the long-expired Relative JSON Pointer I-D. Maybe
that's OK since this is not even a working group document yet,
or we can talk about how to either move the relevant parts in,
or re-submit that I-D ourselves as well.
This goes along with "hrefPointers" ( #386 ), which adjusts template
variable resolution in the same way that this keyword adjusts
context location.