Reference validation from hyper-schema #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite having a whole section describing how hyper-schema builds on validation, it was never referenced or listed as a normative specifciation. Also, we had labled the meta-schema link as a validation schema in an apparent copy-paste error. Finally, improve wording around building on the other specs in the same way as was done for the validation spec referincing core.
dlax
suggested changes
Aug 23, 2017
jsonschema-hyperschema.xml
Outdated
| @@ -1188,7 +1189,17 @@ GET /foo/ | |||
| </author> | |||
| <date year="2016" month="October"/> | |||
| </front> | |||
| <seriesInfo name="Internet-Draft" value="draft-wright-json-schema-00" /> | |||
| <seriesInfo name="Internet-Draft" value="draft-wright-json-schema-validation-01" /> | |||
There was a problem hiding this comment.
This change looks wrong. The "json-schema" reference points to the "core" document not the "validation" one. Copy/paste error?
There was a problem hiding this comment.
Yup, good catch, will fix.
dlax
approved these changes
Aug 23, 2017
gregsdennis
added
clarification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite having a whole section describing how hyper-schema
builds on validation, it was never referenced or listed
as a normative specifciation.
Also, we had labled the meta-schema link as a validation schema
in an apparent copy-paste error.
Finally, improve wording around building on the other specs in
the same way as was done for the validation spec referincing core.