Add non-http "method": "post" LDO example #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlax
reviewed
Mar 24, 2017
jsonschema-hyperschema.xml
Outdated
| "media": { "type": "text/html" } | ||
| } | ||
| ], | ||
| "minItmes": 2 |
There was a problem hiding this comment.
heh. Maybe I should remember to validate my examples against the meta-schema :-P
Add an example showing how a non-HTTP URI scheme can be used, showing a form for constructing an email with two different representations, as well as requiring a subject.
|
I think this makes sense. This is a lot like how you would do it with an HTML Form. |
|
@awwright if you agree with @jdesrosiers that this is reasonable, should we go ahead and add it to Draft 06? It shouldn't change anything, only clarify. |
|
It's maybe a bit more verbose than ought to be necessary, but still, a good illustration of this behavior is probably warranted. |
|
@awwright I tend to be verbose, unfortunately. Anything in particular you'd trim? |
|
@awwright did that comment count as an approval? |
awwright
approved these changes
Mar 27, 2017
|
I think I just needed to sit on it another day. Looks good. |
|
@awwright thanks! Totally reasonable, just wasn't quite clear :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR need not necessarily go into Draft 06
I'm posting this mostly to illustrate some of the arguments in #280, particularly around avoiding coupling of JSON Hyper-Schema and any particular URI scheme or protocol.
If we can't figure out a reasonable mapping for
mailto:then we might be missing something. Although that something will probably need to wait until Draft 07 for a fix.I am aware that it's more common to use an HTTP request to ask the server to send mail, but I think this still makes a good example. If the client for this resource runs in a known environment, it could be reasonable to expect the client to send mail if it wants to.
Add an example showing how a non-HTTP URI scheme can be used,
showing a form for constructing an email with two different
representations, as well as requiring a subject.