Fix prefixItems keyword omitted behavior
#1481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregsdennis
reviewed
Jan 20, 2024
| @@ -1844,8 +1844,6 @@ this keyword applied a subschema. The value MAY be a boolean true if a subschema | |||
| was applied to every index of the instance, such as is produced by the `items` | |||
| keyword. This annotation affects the behavior of `items` and `unevaluatedItems`. | |||
|
|
|||
| Omitting this keyword has the same assertion behavior as an empty array. | |||
There was a problem hiding this comment.
We still need to specify what the behavior of omitting the keyword is. (Either that or remove all other omission clauses; probably not.)
There was a problem hiding this comment.
Compare to allOf and friends, just removing it is consistent with how they are. Plenty of other keywords don't include a comparable sentence.
karenetheridge
approved these changes
Jan 20, 2024
jdesrosiers
approved these changes
Jan 21, 2024
notEthan
force-pushed
the
prefixItems-omitted
branch
from
63465c6 to
99f57cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1480 to omit the sentence about omitting the keyword, as
allOfetc do.Also fixes a small markdown error while I'm touching that section.