Skip to content

Update properties and patternProperties annotation language #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 20, 2022
Merged

Update properties and patternProperties annotation language #1345

merged 4 commits into from
Nov 20, 2022

Conversation

gregsdennis
Copy link
Member

Resolves #1310

Improves the annotation definition language for properties and patternProperties.

properties - replaced "match" language to be more explicit
patternProperties - clarified "match" language

@gregsdennis
Copy link
Member Author

@handrews made a comment that the introduction of "A Vocabulary for Unevaluated Locations" will need to be updated, but after reading it, I'm not sure what was meant. I think the changes present so far in this PR are sufficient to satisfy the need I expressed in the issue.

handrews
handrews approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@handrews handrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure that whatever I was talking about with the unevaluated vocabulary was not directly about this specific wording change.

karenetheridge
karenetheridge requested changes Oct 30, 2022
View reviewed changes
gregsdennis and others added 2 commits November 7, 2022 08:53
@gregsdennis @karenetheridge
Incorporate suggested change
7513902 
Co-authored-by: Karen Etheridge <[email protected]>
@gregsdennis @karenetheridge
Incoporate suggested change
ee931a0 
Co-authored-by: Karen Etheridge <[email protected]>
@gregsdennis
Copy link
Member Author

@karenetheridge I've incorporated your updates. Can you re-review, please?

@gregsdennis gregsdennis merged commit d962a20 into main Nov 20, 2022
@gregsdennis gregsdennis deleted the gregsdennis-property-annotation-language-update branch November 20, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karenetheridge karenetheridge karenetheridge approved these changes

@handrews handrews handrews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Annotation specification of properties could be improved
3 participants
@gregsdennis @karenetheridge @handrews