Skip to content

add droppedAnnotations #1329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 6, 2022
Merged

add droppedAnnotations #1329

merged 4 commits into from
Nov 6, 2022

Conversation

gregsdennis
Copy link
Member

Partially addresses #1319.

This adds droppedAnnotations to the output unit as an optional field. While they can be useful for debugging, these annotations are usually just noise.

@gregsdennis gregsdennis requested a review from a team October 26, 2022 20:57
handrews
handrews approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@handrews handrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I raised a concern but it's not a blocker.

@gregsdennis gregsdennis merged commit 47753d9 into main Nov 6, 2022
@gregsdennis gregsdennis deleted the gregsdennis-annotation-inclusion-requirements branch November 6, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@handrews handrews handrews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregsdennis @handrews