Skip to content

wording fixes for the interim release #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

karenetheridge
Copy link
Member

This is an amended and abridged version of the changes proposed in #1110. This only contains clarifications; any changes to behaviour must be reserved for a future specification revision.

@Relequestual Relequestual changed the base branch from draft-next to master December 6, 2021 11:56
@Relequestual
Copy link
Member

Saw too many commits because the target draft-next rather than master. Changing PR target to master` resolved the "woah that's a lot of commits from ages ago" issue. =]

@Relequestual Relequestual added this to the draft-patch for 2020-12 milestone Dec 6, 2021
Copy link
Member

@jdesrosiers jdesrosiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely an improvement. Just one thing that doesn't look quite right.

RFC3339 refers to these as "formats". The XML xs:NCName specification refers to it as a "type".
We are tying our implementation to the ABNF rules explicitly, so refer to those.
- More cross-references added that note the dependence of these keywords on each other
- Confusing paragraph about logical results removed (and it is redundant with other paragraphs)
@karenetheridge karenetheridge force-pushed the ether/interim-wording-fixes branch from 1937ccd to 0ced791 Compare December 21, 2021 21:59
@karenetheridge
Copy link
Member Author

I've reworked the "contains" section from scratch and hopefully it is more clear (and with fewer falsehoods) now.

Copy link
Member

@Relequestual Relequestual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, I left a review unsubmitted for a while!
Few minor suggestions, but otherwise looks ideal.

karenetheridge and others added 2 commits February 3, 2022 20:14
@Relequestual Relequestual merged commit 8d59764 into json-schema-org:master Feb 4, 2022
@karenetheridge karenetheridge deleted the ether/interim-wording-fixes branch March 20, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants