-
-
Notifications
You must be signed in to change notification settings - Fork 311
wording fixes for the interim release #1155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wording fixes for the interim release #1155
Conversation
Saw too many commits because the target |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely an improvement. Just one thing that doesn't look quite right.
RFC3339 refers to these as "formats". The XML xs:NCName specification refers to it as a "type". We are tying our implementation to the ABNF rules explicitly, so refer to those.
- More cross-references added that note the dependence of these keywords on each other - Confusing paragraph about logical results removed (and it is redundant with other paragraphs)
1937ccd
to
0ced791
Compare
I've reworked the "contains" section from scratch and hopefully it is more clear (and with fewer falsehoods) now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies, I left a review unsubmitted for a while!
Few minor suggestions, but otherwise looks ideal.
Co-authored-by: Ben Hutton <[email protected]>
This is an amended and abridged version of the changes proposed in #1110. This only contains clarifications; any changes to behaviour must be reserved for a future specification revision.