-
-
Notifications
You must be signed in to change notification settings - Fork 309
Defines what happens when relative JSON pointer starts with zero #1147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
https://tools.ietf.org/id/draft-handrews-relative-json-pointer-00.html#rfc.section.3 The spec already says that relative JSON pointers must start with positive integers. Maybe we just remove "non-negative". |
It quantifies in the ABNF...
This is also shown in the proceeding examples...
It's essentially a no-op, but is valid. (FYI latest is https://datatracker.ietf.org/doc/html/draft-bhutton-relative-json-pointer-00) |
Then we should either change the section I linked or change the ANBF. They conflict. Personally, I'm happy with either. (It seems "non-negative" is the current term in the latest.) |
You do not believe zero is a non-negative integer? |
My concern was alignment. I didn't care which it was. Positive and non-negative are both fine as long as the spec is consistent. |
It is consistent in the current version. You were viewing the previous 😅 |
Fix typo! Co-authored-by: Ethan <[email protected]>
As there has been little interest, I'm removing this PR and associated issue from the milestone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I find the phrasing slightly awkward, everything else I can think of is also slightly awkward. This is definitely correct on a technical level, should we just go ahead and merge this?
Resolves #1121