Skip to content

Support for IRI references (#59) #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from
Closed

Support for IRI references (#59) #1068

wants to merge 0 commits into from

Conversation

jakubklimek
Copy link
Contributor

This would add support for IRI references in $id, $ref and $dynamicRef as per #59

@Relequestual
Copy link
Member

Please DO NOT MERGE this yet. 2020-12 meta-schema needs to be published.

@Relequestual
Copy link
Member

Additionally, the specification documents would need updating, either first (in a separate PR), or at the same time.

@karenetheridge
Copy link
Member

$vocabulary and $schema use uri - should this be changed to iri?

@jakubklimek
Copy link
Contributor Author

@karenetheridge yes, we want the references to be IRIs as well so that they are also human readable

@handrews
Copy link
Contributor

@jakubklimek I'm going to convert this to a draft as there seems to still be discussion in the issue.

@handrews handrews marked this pull request as draft May 12, 2021 16:14
@handrews handrews changed the base branch from master to draft-next May 19, 2021 19:07
@handrews handrews added this to the draft-next milestone May 19, 2021
@jakubklimek
Copy link
Contributor Author

@Relequestual @handrews I have pushed commits changing URIs to IRIs in the spec as well where necessary. I left references to RFC 3986 (URIs) wherever resolving base URIs is mentioned, as this is also applicable to IRIs and RFC 3987 actually refers to RFC 3986 in this manner.

I would therefore like to resume discussions about merging this.

Copy link
Member

@jdesrosiers jdesrosiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this work! I noticed that there seem to be a few unrelated changes that got mixed in to this PR as well. It looks like it's coming from a merge from master. Could you have a look and clean that up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants