Skip to content

Fix "dynamic" keywords in core vocabulary meta-schema #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2020
Merged

Fix "dynamic" keywords in core vocabulary meta-schema #1029

merged 1 commit into from
Nov 24, 2020

Conversation

jdesrosiers
Copy link
Member

I appears this was missed when updating the meta-schemas to use $dynamicRef and $dynamicAnchor.

Relequestual
Relequestual approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@Relequestual Relequestual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes. Thanks.
I don't think we've been keeping the meta schema up to date and planned to release them AFTER the spec docs themselves.

@Relequestual
Copy link
Member

Ah that would be the general-purpose meta-schema I see. Much appreciated!
It will need a full going over to check it matches up with the vocabulary schemas post draft docs release.

@Relequestual Relequestual merged commit d8c66e2 into json-schema-org:master Nov 24, 2020
@jdesrosiers jdesrosiers deleted the fix-core-schema branch July 8, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Relequestual Relequestual Relequestual approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
draft-08-patch1 (draft 2020-12)
Development

Successfully merging this pull request may close these issues.
2 participants
@jdesrosiers @Relequestual