Skip to content
This repository was archived by the owner on Nov 2, 2023. It is now read-only.

Add/implementation json schema library #441

Conversation

sagold
Copy link
Contributor

@sagold sagold commented Apr 23, 2022

Dear all,

with this pr, json-schema-library is added to the list of javascript validator and utility implementations. It does support draft 4 to 7 and is part of the json-schema-benchmark. Unfortunately, the benchmark has not been updated since 17 months so I ran and uploaded an update here: https://github.com/sagold/json-schema-benchmark.

Happy to have this library in your list. Thank you very much for your work on json-schema.

Cheers,
Sascha

@netlify
Copy link

netlify bot commented Apr 23, 2022

Deploy Preview for condescending-hopper-c3ed30 ready!

Name Link
🔨 Latest commit 1ad3d13
🔍 Latest deploy log https://app.netlify.com/sites/condescending-hopper-c3ed30/deploys/626443fef97d6c0008362e3d
😎 Deploy Preview https://deploy-preview-441--condescending-hopper-c3ed30.netlify.app/implementations
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Relequestual
Copy link
Member

Relequestual commented Apr 25, 2022

@sagold I can see you're using @json-schema-org/tests.
Despite the org naming, this isn't something that's activley maintained right now.

We suggest using the test repo as a submodule in your git repo, and loading and processing the JSON it contains. This will be much more current than the outdated npm package.

If it's not much effort, please do come back once you've done so =]

Thank you for your effort and hard work on building the implementation, and for making this PR.

@sagold
Copy link
Contributor Author

sagold commented May 8, 2022

Hi @Relequestual,

thank you for the hint. I updated the dependency to reference the latest commit directly (in package.json, not as a submodule), replaced the test-module by a custom test-loader and merged the changes to master: sagold/json-schema-library@7ce21e8.

let me know if you still miss something.

Cheers,
Sascha

@Relequestual
Copy link
Member

Thanks @sagold! Bravo.

The test files on npm need attention. They aren't as of yet "official" although they may seem to be due to the org prefix.

LGTM!

@Relequestual Relequestual merged commit d20501c into json-schema-org:master May 9, 2022
@Relequestual
Copy link
Member

Did you know we have a JSON Schema slack server?
I invite you and your collaborators to join us! =]

FYI: The extensions you've created could be formed into their own reuseable vocabulary, if you so wanted.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants