Skip to content
This repository was archived by the owner on Nov 2, 2023. It is now read-only.

2020 12 update #369

Merged
merged 13 commits into from
Feb 20, 2021
Merged

Conversation

Relequestual
Copy link
Member

@Relequestual Relequestual commented Feb 3, 2021

This SHOULD be all the changes required for 2020-12.

There should be a build preview appearing just below this comment.

I've also added local build instructions to the readme should you want to run it locally to test any changes.

@netlify
Copy link

netlify bot commented Feb 3, 2021

Deploy preview for condescending-hopper-c3ed30 ready!

Built with commit 2f21a83

https://deploy-preview-369--condescending-hopper-c3ed30.netlify.app

@karenetheridge
Copy link
Member

I'm not sure if these are problems, or just weirdness with the preview:

@jdesrosiers
Copy link
Member

All of the schema examples under /learn have a $schema set as draft-07. Those should all be updated to the latest draft.

@jdesrosiers
Copy link
Member

When we posted the draft 2020-12 review in slack, there was some confusion about Relative JSON Pointer's role in JSON Schema. It might be prudent to address that confusion when we publish the website. A note on the specifications page should be enough.

@Relequestual
Copy link
Member Author

I'm not sure if these are problems, or just weirdness with the preview:

* Understanding JSON Schema is a 404 on https://deploy-preview-369--condescending-hopper-c3ed30.netlify.app/,

That's fine. That path specifically is published under the other repo. It's weird but managed by github settings and it works!

* the metaschema and vocabulary links to go a text file with content like "../../../_includes/draft/2020-12/meta/core.json" on https://deploy-preview-369--condescending-hopper-c3ed30.netlify.app/specification.html
  and
  https://deploy-preview-369--condescending-hopper-c3ed30.netlify.app/specification-links.html#2020-12

I may need to update submodules, or I forgot to include the update for submodules. Checking.

@Relequestual
Copy link
Member Author

* the metaschema and vocabulary links to go a text file with content like "../../../_includes/draft/2020-12/meta/core.json"

@karenetheridge looks like I just made text files rather than the actual symlinks... oops.

@Relequestual
Copy link
Member Author

When we posted the draft 2020-12 review in slack, there was some confusion about Relative JSON Pointer's role in JSON Schema. It might be prudent to address that confusion when we publish the website. A note on the specifications page should be enough.

@jdesrosiers I'm going to make a new issue for this as I'm not really sure what you had in mind, and I don't want to delay this PR any longer than required.

Copy link
Contributor

@philsturgeon philsturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, with the OAS3.1 announcement it would be good to get this up ASAP.


Specification documents
-----------------------

See also the [release notes / change log](draft/2019-09/release-notes.html).
See also the release notes / change log (Work in progress).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets link to the page, it alread ysays its a work in progress when they get there. One less thing to remember to update.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good plan. I can't make the change right now, but feel free to make a change suggestion =]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh skip it and merge, this is good.

@philsturgeon
Copy link
Contributor

Fixed the conflict, let's press on and make more improvements shortly.

@jdesrosiers
Copy link
Member

jdesrosiers commented Feb 18, 2021

All of the schema examples under /learn have a $schema set as draft-07. Those should all be updated to the latest draft.

This hasn't been addressed yet. I'll send a PR shortly.

Add warning that Rel JSON Pointer is not used
@Relequestual
Copy link
Member Author

All of the schema examples under /learn have a $schema set as draft-07. Those should all be updated to the latest draft.

This hasn't been addressed yet. I'll send a PR shortly.

Given it hasn't been updated since draft-07, and we've had 2019-09 since then, I'm going to say this should be covered by the load of docs work that needs to be done, not in this PR specifically.

@Relequestual Relequestual merged commit 344f939 into json-schema-org:master Feb 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants