-
-
Notifications
You must be signed in to change notification settings - Fork 213
2020 12 update #369
2020 12 update #369
Conversation
Deploy preview for condescending-hopper-c3ed30 ready! Built with commit 2f21a83 https://deploy-preview-369--condescending-hopper-c3ed30.netlify.app |
I'm not sure if these are problems, or just weirdness with the preview:
|
All of the schema examples under |
When we posted the draft 2020-12 review in slack, there was some confusion about Relative JSON Pointer's role in JSON Schema. It might be prudent to address that confusion when we publish the website. A note on the specifications page should be enough. |
That's fine. That path specifically is published under the other repo. It's weird but managed by github settings and it works!
I may need to update submodules, or I forgot to include the update for submodules. Checking. |
@karenetheridge looks like I just made text files rather than the actual symlinks... oops. |
@jdesrosiers I'm going to make a new issue for this as I'm not really sure what you had in mind, and I don't want to delay this PR any longer than required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, with the OAS3.1 announcement it would be good to get this up ASAP.
|
||
Specification documents | ||
----------------------- | ||
|
||
See also the [release notes / change log](draft/2019-09/release-notes.html). | ||
See also the release notes / change log (Work in progress). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets link to the page, it alread ysays its a work in progress when they get there. One less thing to remember to update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good plan. I can't make the change right now, but feel free to make a change suggestion =]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eh skip it and merge, this is good.
Fixed the conflict, let's press on and make more improvements shortly. |
This hasn't been addressed yet. I'll send a PR shortly. |
Add warning that Rel JSON Pointer is not used
Given it hasn't been updated since draft-07, and we've had 2019-09 since then, I'm going to say this should be covered by the load of docs work that needs to be done, not in this PR specifically. |
This SHOULD be all the changes required for 2020-12.
There should be a build preview appearing just below this comment.
I've also added local build instructions to the readme should you want to run it locally to test any changes.