Skip to content
This repository was archived by the owner on Nov 2, 2023. It is now read-only.

jsoncons C++ library supports JSON Schema Draft 7 #366

Merged
merged 1 commit into from
May 20, 2021

Conversation

danielaparker
Copy link
Contributor

jsoncons C++ library supports JSON Schema Draft 7

@netlify
Copy link

netlify bot commented Jan 19, 2021

✔️ Deploy preview for condescending-hopper-c3ed30 ready!

🔨 Explore the source changes: 140c7e8

🔍 Inspect the deploy logs: https://app.netlify.com/sites/condescending-hopper-c3ed30/deploys/60064ea2e1e34e000852982b

😎 Browse the preview: https://deploy-preview-366--condescending-hopper-c3ed30.netlify.app

@Relequestual
Copy link
Member

Thank you for your contribution.
Have you considered using the test suite via submodule rather than copy paste the test suite?

@danielaparker
Copy link
Contributor Author

Thank you for your contribution.
Have you considered using the test suite via submodule rather than copy paste the test suite?

I hadn't thought about using the test suite via submodule, I don't have experience with submodules. I believe some other implementations that I looked at copied the test suite. I could look into it, if that's an issue for JSON Schema.

@Relequestual
Copy link
Member

@danielaparker It's preferable, as it makes it easier to update, and we can be sure the test suite isn't modified.
Of course, your code could skip specific tests, but then it should be obvious if that's happening.

It's not a hard requirement. It looks like you have a pretty good understanding and act accordingly.
Maybe you could create a new issue in your repo and I'll merge this PR 😀

@Relequestual Relequestual merged commit 6840267 into json-schema-org:master May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants