Skip to content
This repository was archived by the owner on Nov 2, 2023. It is now read-only.

Add UI Schema to implementations; #354

Merged
merged 4 commits into from
Mar 9, 2021

Conversation

elbakerino
Copy link
Contributor

Added @ui-schema/ui-schema under ui generation and the corresponding live editor at editors.

Added @ui-schema/ui-schema under ui generation and the corresponding live editor at editors.
@netlify
Copy link

netlify bot commented Sep 18, 2020

Deploy preview for condescending-hopper-c3ed30 ready!

Built with commit c91e60f

https://deploy-preview-354--condescending-hopper-c3ed30.netlify.app

@netlify
Copy link

netlify bot commented Sep 18, 2020

Deploy preview for condescending-hopper-c3ed30 ready!

Built with commit 6f3d8ad

https://deploy-preview-354--condescending-hopper-c3ed30.netlify.app

I do not feel this is a JSON Schema editor.
@Relequestual
Copy link
Member

It's really cool to see a UI generator which supports draft 2019-09! Great work.
I'm super impressed by the stepped approach. NICE!
I'm a little (or a lot) jealous there's not good vue equivalent (at least that I know of).
I am a fan of THIS.

I modified your PR to remove adding the editor.
I don't feel the live preview is really a JSON Schema editor. It's really a text area with some auto complete.
I don't even list my own similar sandbox thing because it doesn't offer comparable features to an editor.
I hope you can understand my reasoning.

I've put this PR on hold. There are a few things I'd like to see addressed before adding you to the list.

  • We ask libraries to always make clear the supported drafts of JSON Schema on their site. I can't see that, and I'd expect to see it on the home page. Given you support a good number, including 2019-09, this is super important, especially if I'm going to direct people there.

  • The "documentation" link on the home page in the body content takes me to a 404. The "home" link on the 404 page also leads to a 404. 😬 Minior I know.


Two things unrelated to this PR...

You should join our JSON Schema slack server. People are always asking about form generation, and it's a great place to hear about what's coming in the next version of JSON Schema, and even influence that outcome.

The way in which you've added keywords to JSON Schema is a great candidate for a new vocabulary.
I'd like to be able to guide you (and maybe a few others) through the process of formalising a vocabulary for UI and form generation. (I'm on the JSON Schema slack server under the same username.)

@Relequestual
Copy link
Member

Relequestual commented Sep 18, 2020

/remind me to look at this again in 7 days. (huh I guess the reminder bot only works on issues? =/)
PR marked as on hold as there isn't actually anything in the PR that needs to change now.

@elbakerino
Copy link
Contributor Author

elbakerino commented Sep 18, 2020

Thanks for the praise! There are still a few things missing, as just reaching v0.1.0, I'm always discovering new keywords in the spec. which i missed :D First version was only supporting what was available in the understanding book.

If someone likes to implement a similiar render engine in Vue, i would be glad to share typings and pure JS parts - there should be a lot not React dependent logic which could be bridged, e.g. shared validator plugin interfaces.

Alright with the editor, wasn't sure about it also.

The schema and related keyword support is the last point of features in github and on the homepage under documentation > schema

Thanks for the link info! Removed it, the page was deleted as the menu should be enough.

Regarding the vocabularies, would love to learn how to write them, already tried it at the beginning, ui-schema/2019-09/meta/view (the $id link is also broken i realize now), and created some rather complex JSON Schema typing to support nested schemas.

@Relequestual
Copy link
Member

Documentation link on https://ui-schema.bemit.codes/ still leads to a 404 =]

@elbakerino
Copy link
Contributor Author

Oh, that somehow sneaked in again, is removed.

@Relequestual Relequestual merged commit 27a9e41 into json-schema-org:master Mar 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants