Skip to content
This repository was archived by the owner on Nov 2, 2023. It is now read-only.

Add Vert.x Json Schema among the implementations #345

Merged
merged 3 commits into from
Jan 28, 2021

Conversation

slinkydeveloper
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Jul 7, 2020

Deploy preview for condescending-hopper-c3ed30 ready!

Built with commit c1564d6

https://deploy-preview-345--condescending-hopper-c3ed30.netlify.app

@slinkydeveloper
Copy link
Contributor Author

@handrews can you check this one please? 😄

@Relequestual
Copy link
Member

Hey. Although you have specified which drafts you support in this PR, could you do the same in the project's readme, please?

Additionally, I took a quick look but I couldn't tell, are you using the official test suite?

Thanks =]

@slinkydeveloper
Copy link
Contributor Author

Hey. Although you have specified which drafts you support in this PR, could you do the same in the project's readme, please?

It's here: https://vertx.io/docs/vertx-json-schema/java/
Maybe I should link this page more than the github repo?

Additionally, I took a quick look but I couldn't tell, are you using the official test suite?

Yep, here it is: https://github.com/eclipse-vertx/vertx-json-schema/tree/master/src/test/resources/tck

@Relequestual
Copy link
Member

Hey. Although you have specified which drafts you support in this PR, could you do the same in the project's readme, please?

It's here: https://vertx.io/docs/vertx-json-schema/java/
Maybe I should link this page more than the github repo?

I think all the links go to the github repo. I've seen too many sites go offline after a few years.

Additionally, I took a quick look but I couldn't tell, are you using the official test suite?

Yep, here it is: https://github.com/eclipse-vertx/vertx-json-schema/tree/master/src/test/resources/tck

Ah super! I haven't touched Java in years =]

@Relequestual
Copy link
Member

Looks like I've not always been strict on the github readme draft support notice, so in the interest of fairness...

Only fair to add it to the END of the list for the same draft support.
@Relequestual
Copy link
Member

I made a change so waiting on checks...

@Relequestual Relequestual merged commit af93843 into json-schema-org:master Jan 28, 2021
@slinkydeveloper
Copy link
Contributor Author

Thanks!

@slinkydeveloper slinkydeveloper deleted the patch-1 branch January 28, 2021 16:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants