This repository was archived by the owner on Nov 2, 2023. It is now read-only.
Update implementations.md #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appeared that qri-io/jsonschema doesn't do code to schema generation (qri-io/jsonschema#32). Replaced it with this one https://github.com/alecthomas/jsonschema in the list of Golang code to schema generation implementations
|
Deploy preview for condescending-hopper-c3ed30 ready! Built with commit 8fb1b9a https://deploy-preview-340--condescending-hopper-c3ed30.netlify.app |
|
Thanks for your PR. Removing the implementation makes sense. |
Removed implementation reference
|
Agreed, thanks, committed the relevant change |
|
Thanks for helping out and being a good citizen! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appeared that qri-io/jsonschema doesn't do code to schema generation (qri-io/jsonschema#32). Replaced it with the one https://github.com/alecthomas/jsonschema in the list of Golang code to schema generation implementations