Skip to content
This repository was archived by the owner on Nov 2, 2023. It is now read-only.

Add networknt json-schema-validator to the Java validator list #302

Merged
merged 3 commits into from
Nov 13, 2019

Conversation

stevehu
Copy link
Contributor

@stevehu stevehu commented Nov 8, 2019

No description provided.

@netlify
Copy link

netlify bot commented Nov 8, 2019

Deploy preview for condescending-hopper-c3ed30 ready!

Built with commit e4fd78f

https://deploy-preview-302--condescending-hopper-c3ed30.netlify.com

@slisaasquatch
Copy link
Contributor

I'm not part of this project, but I think your project already exists in the obsolete list, so you might want to remove it there.

@handrews
Copy link
Contributor

I'm confused- #303 looked like it fixed both files but was closed?

@slisaasquatch
Copy link
Contributor

I'm confused- #303 looked like it fixed both files but was closed?

Sorry, I created that pull request before I realized this one existed, and this one is from the original author of the library. So I closed mine.

@handrews
Copy link
Contributor

OK yeah, agree this should also be removed from implementations-obsolete.md

@handrews
Copy link
Contributor

If the OP doesn't fix it we'll edit it further and merge it eventually

@stevehu
Copy link
Contributor Author

stevehu commented Nov 12, 2019

@slisaasquatch @handrews Thanks for pointing out the obsolete list. I have removed it from the list already.

@Relequestual Relequestual merged commit 75e8fe2 into json-schema-org:master Nov 13, 2019
@Relequestual
Copy link
Member

Thanks Steve! Merged!

As an aside, taking a quick look, I couldn't tell if you used the official test suite or not.
It looks like you may in some places, but also have additional tests. Is that right?

@stevehu
Copy link
Contributor Author

stevehu commented Nov 13, 2019

@Relequestual You are right. The library is used in the light-4j framework to validate the request/response during runtime. It has a configuration to switch between pure JSON schema validation and OpenAPI 3.0 schema validation as there are some differences. I will sync with the latest official test cases again. Thanks a lot for the reminder.

@Relequestual
Copy link
Member

@stevehu Super! At least you recognise there are differences and they matter!
Scroll back far enough in closed issues to find someone who was convinced the difference didn't matter... needless to say, I wouldn't list their implementation...

@handrews
Copy link
Contributor

@stevehu fortunately in the future, OpenAPI 3.1 will use a fully compatible superset of JSON Schema draft 2019-09 (formerly known as draft-08), and present the extensions as a recognizable JSON Schema vocabulary, so eventually such special-casing won't be needed anymore.

@stevehu
Copy link
Contributor Author

stevehu commented Nov 13, 2019

@handrews That is what I have heard. I am so glad two teams are working together :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants