This repository was archived by the owner on Nov 2, 2023. It is now read-only.
Redirect the standard vocabulary URIs #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've already had one person confused that these URIs 404, even though the spec says to expect that. Let's generate HTML stubs to redirect to the appropriate spec section for each vocabulary (or the whole spec for Hyper-Schema). No media type restrictions are given at this time for vocabulary documents, so having HTML here is fine. Jekyll (at least the local version, production sometimes differs) will do the redirect on URIs without the .html suffix, which is what we need. It will also do it with .html, but I think that's fine.
handrews
requested review from
philsturgeon,
awwright,
Relequestual and
gregsdennis
|
Deploy preview for condescending-hopper-c3ed30 ready! Built with commit 96b5569 https://deploy-preview-299--condescending-hopper-c3ed30.netlify.com |
|
👍 make that [at least] two people, it took me longer than I'll actually admit to figure out these URLs. |
Relequestual
approved these changes
Oct 30, 2019
|
Follow up question. Should the URIs which are not supposed to be network accessable, be un-linked in the specification and in stead just be encased in quotes? |
|
It's best practice to put something at the target URI, even if it's not machine readable. e.g. https://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul |
philsturgeon
approved these changes
Oct 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've already had one person confused that these URIs 404, even
though the spec says to expect that. Let's generate HTML stubs
to redirect to the appropriate spec section for each vocabulary
(or the whole spec for Hyper-Schema).
No media type restrictions are given at this time for vocabulary
documents, so having HTML here is fine. Jekyll (at least the
local version, production sometimes differs) will do the redirect
on URIs without the .html suffix, which is what we need. It will
also do it with .html, but I think that's fine.