This repository was archived by the owner on Nov 2, 2023. It is now read-only.
Support date-based drafts, update Manatee.JSON #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jekyll/Liquid are limiting so this gets more complicated to display correctly.
|
I've been advertising it on my readme, so go for it. |
gregsdennis
approved these changes
Oct 24, 2019
| @@ -3,63 +3,75 @@ | |||
| implementations: | |||
| - name: Json.NET Schema | |||
| url: https://www.newtonsoft.com/jsonschema | |||
| date-draft: | |||
There was a problem hiding this comment.
Wait why not just draft: ["2019-09", 7, 6, 4, 3] ?
There was a problem hiding this comment.
@philsturgeon you have to make something somewhere more complicated, this was the easiest option in the <10 minutes I was willing to spend on it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gregsdennis any reason not to start advertising support? We keep getting asked if anyone supports 2019-09 at all.
Jekyll/Liquid are limiting so this gets more complicated to display correctly. It's fine to leave
date-draft:out of a section, but I added it in to increase the chance that other people will get it right.