Skip to content
This repository was archived by the owner on Nov 2, 2023. It is now read-only.

Add pre-release table styling from minima #161

Merged
merged 1 commit into from
Oct 1, 2017

Conversation

adamvoss
Copy link
Contributor

@adamvoss adamvoss commented Oct 1, 2017

Pilfered from jekyll/minima#144
Once a new version of minima is released, this (an the include in main.scss can probably be deleted.

Copy link
Contributor

@handrews handrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome- thanks so much!

The other tables looked fine, but the release notes just have too much text. And I couldn't figure out how to affect just them (admittedly, I did not try super-hard)

@handrews handrews merged commit 3bdac9a into json-schema-org:master Oct 1, 2017
@adamvoss
Copy link
Contributor Author

adamvoss commented Oct 1, 2017

This affects all tables too, but I didn't think the other places looked bad with this. Normal CSS tricks (if you even call them that) would need to be used to isolate what is affected by some sort of selector.

@handrews
Copy link
Contributor

handrews commented Oct 1, 2017

@adamvoss yeah, they look fine. And looking at them like this they look like reasonable use of tables as opposed to my cranky complaint about layout :-P

@adamvoss adamvoss deleted the tableStyling branch October 1, 2017 01:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants