Skip to content
This repository was archived by the owner on Nov 2, 2023. It is now read-only.

Fixed minimum & exclusiveMinimum docs #116

Closed
wants to merge 1 commit into from

Conversation

brandonkelly
Copy link

No description provided.

@adamvoss
Copy link
Contributor

@brandonkelly Nice catch! Is there a corresponding issue or pull request for this in the spec repository?

@handrews
Copy link
Contributor

@brandonkelly yes, thanks! This does need to be fixed over at json-schema-org/json-schema-spec in the XML files there. The files here are only generated from those when a new draft is published.

We should probably be more clear about that somewhere, this isn't the first time someone has submitted a fix here.

@adamvoss
Copy link
Contributor

@handrews
From the README:

This repo is currently undergoing a complete restructuring and removing of content not related to the website. It was a copy of the gh-pages branch over on the old org repo.

Is that comment still accurate? I agree there is room for improvement, and I am trying to think of the best way to make the relationship more clear. However, the proper approach may depend on what refactoring is in mind.

@brandonkelly
Copy link
Author

@vossad01 looks like yes: json-schema-org/json-schema-spec#320

@handrews just submitted a PR over at the json-schema-org/json-schema-spec repo: json-schema-org/json-schema-spec#323 - sorry for missing that!

@handrews
Copy link
Contributor

Is that comment still accurate? I agree there is room for improvement, and I am trying to think of the best way to make the relationship more clear. However, the proper approach may depend on what refactoring is in mind.

I'm not really sure if @Relequestual has anything in mind. There has not been talk of a specific major refactoring that I know of. It should be safe to rewrite that, it's not like it would prevent us from undertaking a further refactoring! :-)

@Relequestual
Copy link
Member

I can't really remember what I had in mind. In addition, I like the approach I've seen of moving as much as possible to markdown.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants